feature/totp-flow #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add meta data to user on sign up - invite user by email
Owner
|
Very nice! Will take a look next weekend or so! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @tschuehly,
I have another PR for you but I don't expect you to merge it as is because I saw you refactored a bit more in the
SNAPSHOTand this is not yet as complete as you'd want it to be (missing exception handling and tests). Still I thought this may be usefull for you if you refactor it a little.Here is a short overview:
runGoTrueWithResult()to be able to pass a result (e.g. I use your starter in a Spring Boot app and there is further business logic which needs the results of the service)Have a great start into the week and keep up the great work :)