-
Notifications
You must be signed in to change notification settings - Fork 92
fix: board width and height should be undefined when outline is provided #1614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Enity300
wants to merge
17
commits into
tscircuit:main
Choose a base branch
from
Enity300:reproduce-issue-1516
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 14 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
366a0c1
fix: board width and height should be undefined when outline is provided
Enity300 6cb9e8e
fix: update board-outline-dimension test and format repro70 test
Enity300 ceb423d
fix: remove extra blank line in repro70 test
Enity300 0cc18d3
fix: remove 'as any' typecast and update snapshot
Enity300 8e3d4c8
This change resolves issue where the absence of the shape property ca…
Enity300 637f660
Merge main into reproduce-issue-1516: resolve conflict in circuit-jso…
Enity300 9cf944c
Resolve merge conflict with main branch
Enity300 2edf4f3
Apply code formatting
Enity300 ab5bbf4
Update Board.ts
Enity300 90d7a92
Update to circuit-json 0.0.303 and fix width/height undefined errors
Enity300 faa97d8
Merge branch 'main' into reproduce-issue-1516
Enity300 8faed95
Apply code formatting
Enity300 6d54cc7
Update tests/fixtures/extend-expect-3d-matcher.ts
Enity300 85b7360
Update tests/fixtures/extend-expect-3d-matcher.ts
Enity300 6517fb6
reduced the scope to shape prop
Enity300 f97e4b6
Merge branch 'reproduce-issue-1516' of https://github.com/Enity300/co…
Enity300 f90bd5d
Merge branch 'main' into reproduce-issue-1516
Enity300 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| import { test, expect } from "bun:test" | ||
| import { getTestFixture } from "tests/fixtures/get-test-fixture" | ||
|
|
||
| test("board width and height should be undefined when outline is provided", async () => { | ||
| const { circuit } = getTestFixture() | ||
|
|
||
| circuit.add( | ||
| <board | ||
| outline={[ | ||
| { x: -8, y: -8 }, | ||
| { x: 8, y: -8 }, | ||
| { x: 8, y: 8 }, | ||
| { x: -8, y: 8 }, | ||
| ]} | ||
| > | ||
| <resistor name="R1" resistance="10k" footprint="0402" /> | ||
| <capacitor name="C1" capacitance="10uF" footprint="0603" /> | ||
| </board>, | ||
| ) | ||
|
|
||
| circuit.render() | ||
|
|
||
| const pcb_board = circuit.db.pcb_board.list()[0] | ||
|
|
||
| // EXPECTED: width and height should be undefined when outline is present | ||
| expect(pcb_board.width).toBeUndefined() | ||
| expect(pcb_board.height).toBeUndefined() | ||
|
|
||
| // EXPECTED: outline should exist and have the correct points | ||
| expect(pcb_board.outline).toBeDefined() | ||
| expect(pcb_board.outline).toHaveLength(4) | ||
| }) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
introduces bug