Skip to content

fix staircase lines #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix staircase lines #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions olive.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,6 @@ void olivec_draw_line(uint32_t *pixels, size_t pixels_width, size_t pixels_heigh
int x1, int y1, int x2, int y2,
uint32_t color)
{
// TODO: fix the olivec_draw_line stairs
int dx = x2 - x1;
int dy = y2 - y1;

Expand All @@ -122,16 +121,23 @@ void olivec_draw_line(uint32_t *pixels, size_t pixels_width, size_t pixels_heigh
if (x1 > x2) OLIVEC_SWAP(int, x1, x2);
for (int x = x1; x <= x2; ++x) {
if (0 <= x && x < (int) pixels_width) {
int sy1 = dy*x/dx + c;
int sy2 = dy*(x + 1)/dx + c;
if (sy1 > sy2) OLIVEC_SWAP(int, sy1, sy2);
for (int y = sy1; y <= sy2; ++y) {
if (0 <= y && y < (int) pixels_height) {
pixels[y*pixels_width + x] = color;
}
int y = dy*x/dx + c;
if (0 <= y && y < (int) pixels_height) {
pixels[y*pixels_width + x] = color;
}
}
}
if (dy != 0){
if (y1 > y2) OLIVEC_SWAP(int, y1, y2);
for (int y = y1; y <= y2; ++y) {
if (0 <= y && y < (int) pixels_height) {
int x = ((y-c)*dx)/dy;
if (0 <= x && x < (int) pixels_width) {
pixels[y*pixels_width + x] = color;
}
}
}
}
} else {
int x = x1;
if (0 <= x && x < (int) pixels_width) {
Expand Down