Skip to content

WIP: Allow uploadLengthDeferred for normal, non-stream files #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

WIP: Allow uploadLengthDeferred for normal, non-stream files #256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions demos/browser/demo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ function startUpload() {
chunkSize: chunkSize,
retryDelays: [0, 1000, 3000, 5000],
parallelUploads: parallelUploads,
uploadLengthDeferred: false,
metadata: {
filename: file.name,
filetype: file.type
Expand Down
3 changes: 2 additions & 1 deletion lib/browser/fileReader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@ class FileSource {
}

const value = this._file.slice(start, end);
return Promise.resolve({ value });
const done = end >= this.size;
return Promise.resolve({ value, done });
}

close() {
Expand Down
6 changes: 4 additions & 2 deletions lib/node/fileReader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,10 @@ class BufferSource {
}

slice(start, end) {
let value = this._buffer.slice(start, end);
const value = this._buffer.slice(start, end);
value.size = value.length;
return Promise.resolve({ value });
const done = end >= this.size;
return Promise.resolve({ value, done });
}

close() {}
Expand Down Expand Up @@ -75,6 +76,7 @@ class StreamSource {
let buf = this._buf.slice(bufStart, bufEnd);
buf.size = buf.length;

// TODO: Do we need to add the dpme value here?
return Promise.resolve({ value: buf });
}

Expand Down