Fix: retryable error on final chunk request fails deferred length uploads #794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, if the last chunk upload resulted in a retryable error, the retry will not have the `Upload-Length` header set and the retry will fail. Since there is no need to remove `upload._uploadLengthDeferred` and doing so results in the header not being set on the retry, this PR leaves it set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed while testing out retry behavior on a deferred length upload that if the final chunk request received a retryable error response from the server, the retry would fail due to a missing
Upload-Lengthheader and the upload would not be recoverable. I was able to stably reproduce the issue by pointing to a local tusd server set to 409 whenever theUpload-Lengthheader was present.As far as I can tell, nothing hangs on
this._uploadLengthDeferredbeing set tofalseon the final chunk request, and it's necessary for it to be present on a retry so the retry gains theUpload-Lengthheader, so the simplest solution is just to remove this line.