-
Notifications
You must be signed in to change notification settings - Fork 37
fix: create clip api method and change response type #498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updates the create-clip request to use the POST method Also includes docs changes to align the documentation with the latest current twitch documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do wonder why we return a vector of clips rather than one. That would be a breaking change, though. So we should keep that in mind when we do a 0.x
bump.
The twitch API documentation here specifies that the response is an array
Not sure if you have any way built into your response handling to transform that? |
Co-authored-by: nerix <nero.9@hotmail.de>
Yea, all responses from Twitch are arrays (not sure why).
We have |
Could we change the response type in the
|
I have updated it to use the parse_single_return :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Updates the create-clip API to use the POST method instead of GET along with some minor docs updates
Changes
Related Issues