Skip to content

Migrate to bzlmod, bump deps #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

agluszak
Copy link

What is the goal of this PR?

Bzlmod migration.

What are the changes implemented in this PR?

All rulesets used have been bumped, WORKSPACE file has been removed.
Closes #370. The next step would be to publish this repo to BCR

@typedb-bot
Copy link
Member

PR Review Checklist

Do not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed.


Trivial Change

  • This change is trivial and does not require a code or architecture review.

Code

  • Packages, classes, and methods have a single domain of responsibility.
  • Packages, classes, and methods are grouped into cohesive and consistent domain model.
  • The code is canonical and the minimum required to achieve the goal.
  • Modules, libraries, and APIs are easy to use, robust (foolproof and not errorprone), and tested.
  • Logic and naming has clear narrative that communicates the accurate intent and responsibility of each module (e.g. method, class, etc.).
  • The code is algorithmically efficient and scalable for the whole application.

Architecture

  • Any required refactoring is completed, and the architecture does not introduce technical debt incidentally.
  • Any required build and release automations are updated and/or implemented.
  • Any new components follows a consistent style with respect to the pre-existing codebase.
  • The architecture intuitively reflects the application domain, and is easy to understand.
  • The architecture has a well-defined hierarchy of encapsulated components.
  • The architecture is extensible and scalable.

@mgosk
Copy link

mgosk commented Apr 4, 2024

+1 for merging this PR into master branch. I am already using this change from PR branch.

@alexjpwalker
Copy link
Member

Thanks for the submission. I'm all for Bzlmod migration and this is something we have previously looked into. However it may take some time for the entire org to be ready for migration (and the upgrade to Bazel 7) as we have at least 20 repositories that would need to be migrated. Please continue to depend on your fork for now and we'll revisit this further down the line!

@chickenandpork
Copy link

chickenandpork commented Jan 29, 2025

@alexjpwalker would it be acceptable for @agluszak to complete this bzlmodify PR, push to .bcr, and keep merging/rebasing changes from here to the fork until you're ready to land the bzlmod/bcr features back to this repo?

  • allows bzlmod-updated users to find and use this repo
  • allows @agluszak to ship this PR and work further to all our benefit
  • allows your other repos to remain non-bzlmod longer

@chickenandpork
Copy link

chickenandpork commented Jan 29, 2025

@alexjpwalker Alternatively, you could choose opposite:

  1. a bazel-7 LTS branch in this repo offering existing capability to pre-bzlmod comsumers
  2. the main branch moves forward with bzlmod and BCR

This incurs additional work to back-port bazel-8 changes on main branch into the bazel-7 LTS branch, but that's typical for a long-lived software project.

Some benefits:

  • clearly commit to bzlmod going forward,
  • avoid getting too far behind as the other repos commit to bzlmod/BCR
  • show the bzlmod and BCR as the default deliverable,
  • highlight @agluszak efforts, and
  • avoid others duplicating Andrzej's work because they don't see that the effort's been done already.

Failing to jump up to bzlmod will only make the effort more difficult :(

@alexjpwalker
Copy link
Member

@chickenandpork Hi! The TypeDB team's been a bit swamped with work on the core database (TypeDB) and its tooling, so Bzlmod migration is still on the backburner. However, we have had someone working on upgrading Bazel across the board recently, so I believe we'll be ready to port to Bzlmod fairly soon now. Until then, I think it's best if you continue to depend on this PR (or fork it and patch your fork with further changes you need).

@chickenandpork
Copy link

@chickenandpork Hi! The TypeDB team's been a bit swamped with work on the core database (TypeDB) and its tooling, so Bzlmod migration is still on the backburner.

I understand that this might be low on your priorities; there's always choices.

However, we have had someone working on upgrading Bazel across the board recently, so I believe we'll be ready to port to Bzlmod fairly soon now.

Hey, imagine if that work was already done?

Accepting contributions can accidentally grow your overloaded team. Maybe there's a downside I'm missing, but my intent here was a few suggestions on how to accept the work in parallel and offer to users without huge negative impact to your other swimlanes. I'm sincerely sorry if that's unwelcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bzlmod support
5 participants