-
Notifications
You must be signed in to change notification settings - Fork 54
Migrate to bzlmod, bump deps #402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
PR Review ChecklistDo not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed. Trivial Change
Code
Architecture
|
+1 for merging this PR into master branch. I am already using this change from PR branch. |
Thanks for the submission. I'm all for Bzlmod migration and this is something we have previously looked into. However it may take some time for the entire org to be ready for migration (and the upgrade to Bazel 7) as we have at least 20 repositories that would need to be migrated. Please continue to depend on your fork for now and we'll revisit this further down the line! |
@alexjpwalker would it be acceptable for @agluszak to complete this bzlmodify PR, push to .bcr, and keep merging/rebasing changes from here to the fork until you're ready to land the bzlmod/bcr features back to this repo?
|
@alexjpwalker Alternatively, you could choose opposite:
This incurs additional work to back-port bazel-8 changes on main branch into the bazel-7 LTS branch, but that's typical for a long-lived software project. Some benefits:
Failing to jump up to bzlmod will only make the effort more difficult :( |
@chickenandpork Hi! The TypeDB team's been a bit swamped with work on the core database (TypeDB) and its tooling, so Bzlmod migration is still on the backburner. However, we have had someone working on upgrading Bazel across the board recently, so I believe we'll be ready to port to Bzlmod fairly soon now. Until then, I think it's best if you continue to depend on this PR (or fork it and patch your fork with further changes you need). |
I understand that this might be low on your priorities; there's always choices.
Hey, imagine if that work was already done? Accepting contributions can accidentally grow your overloaded team. Maybe there's a downside I'm missing, but my intent here was a few suggestions on how to accept the work in parallel and offer to users without huge negative impact to your other swimlanes. I'm sincerely sorry if that's unwelcome. |
What is the goal of this PR?
Bzlmod migration.
What are the changes implemented in this PR?
All rulesets used have been bumped, WORKSPACE file has been removed.
Closes #370. The next step would be to publish this repo to BCR