Skip to content

Commit af16f4f

Browse files
brianhelbaintgr
andauthored
Improve Field.formfield(), GeometryField.formfield() methods (#1724)
Co-authored-by: Marti Raudsepp <marti@juffo.org>
1 parent 323b105 commit af16f4f

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

django-stubs/contrib/gis/db/models/fields.pyi

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,9 @@ class GeometryField(BaseSpatialField[_ST, _GT]):
108108
validators: Iterable[_ValidatorCallable] = ...,
109109
error_messages: _ErrorMessagesMapping | None = ...,
110110
) -> None: ...
111-
def formfield(self, **kwargs: Any) -> Any: ... # type: ignore[override]
111+
def formfield( # type: ignore[override]
112+
self, *, form_class: type[GeometryField] | None = ..., geom_type: str = ..., srid: Any = ..., **kwargs: Any
113+
) -> GeometryField: ...
112114
def select_format(self, compiler: Any, sql: Any, params: Any) -> Any: ...
113115

114116
class PointField(GeometryField[_ST, _GT]):

django-stubs/db/models/fields/__init__.pyi

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -205,8 +205,8 @@ class Field(RegisterLookupMixin, Generic[_ST, _GT]):
205205
# TODO: plugin support
206206
def formfield(
207207
self,
208-
form_class: type[forms.Field] | None = ...,
209-
choices_form_class: Any | None = ...,
208+
form_class: type[Field] | None = ...,
209+
choices_form_class: type[forms.ChoiceField] | None = ...,
210210
**kwargs: Any,
211211
) -> Field: ...
212212
def save_form_data(self, instance: Model, data: Any) -> None: ...

0 commit comments

Comments
 (0)