Update rest_framework.renderers.BaseRenderer.format, media_type #705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
requested changes
Dec 4, 2024
|
(misclick) |
intgr
reviewed
Sep 19, 2025
There was a problem hiding this comment.
Sorry, I'm a little apprehensive about this change.
I think I had a look at this some time ago and came to the conclusion that any actual subclass of BaseRenderer must assign strictly non-None value to the media_type field. If it's None, DRF would actually crash.
So None is actually not a valid value to these fields. It's just a placeholder in the "abstract base class".
Typehinting this as str | None might mislead someone who tries to implement their own Renderer.
🟢 But what we should do is add comments explaining this & move the allowlist_todo.txt entry into allowlist.txt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made things!
Related issues