Cross granularity output debugging #778
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing VEGN output was an erroneous mix of total and structural nitrogen. This commit splits the outputs to be specifically total, structural, or labile. Total N is not available by pft or compartment due to the limitations of labile N. Any calibration workflow will need to be modified to use VEGNSTR instead of VEGN.
LFNV is LitterFall Non-Vascular
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first round of resolving differences between
different granularities of output (e.g. by-PFT outputs
not summing to the associated ecosystem total output).
Splitting the monthly soil updates into pool vs flux is
explicitly marked as needing to be handled correctly post-fire, so
there is a simulation comparison report included here with a single
fire during the transient stage. The formatting of the pdf is
warped by one of the component images, but the contents
indicate no change in the results.
result.pdf