Update Docker images from Ubuntu Focal (20.04) to Ubuntu Jammy (22.04). #787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Focal reaced end of life May 2025.
… issue with define mode. Previoulsly there was not an issue ending define mode. Now with more recent netcdf, it seems like it returns a negative status code if you are already out of define mode and you try to leave it. So here we simply handle that exception case and move on.
One of the tests was failing on a whitespace/formatting difference from printing out the head/tail of a DataFrame. This is a weakness of the doctest arrangement, but here we introduce the pytest library so we can use the pytest.approx(..) function. While this makes the doctest less enjoyable to read, it should be much less brittle.
previous order resulted in unwanted std out in cases of handled errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Focal reached end of life May 2025. This caused build errors when creating the Docker images.