Initial support for hotfix integration as outlined in milestone 6. #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new `/hotfixes` folder in containers and `${PERSISTENT_ROOT}/hotfixes`
with `scripts` and `patches` in it on the host.
Adds a simple script to help apply hotfixes from a folder and installs it in
`/app/apply-hotfixes.sh` in all containers.
All containers mount `${PERSISTENT_ROOT}/hotfixes` on `/hotfixes` and
`docker-entry.sh` is extended to first run `/app/apply-hotfixes.sh`.
It traverses `/hotfixes` and sequentially applies any patches found in
`/hotfix/patches` and runs any scripts found in `/hotfix/scripts` before
proceeding with the usual container execution to effectively hotfix everything
inside the container before running.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
/hotfixesfolder in containers and${PERSISTENT_ROOT}/hotfixeswithscriptsandpatchesin it on the host.Adds a simple script to help apply hotfixes from a folder and installs it in
/app/apply-hotfixes.shin all containers.All containers bind-mount
${PERSISTENT_ROOT}/hotfixeson/hotfixesanddocker-entry.shis extended to first run/app/apply-hotfixes.shon the mounted/hotfixes. It traverses it and sequentially applies any patches found in/hotfix/patches/and runs any scripts found in/hotfix/scripts/before proceeding with the usual container execution to effectively hot-fix everything inside the container before running.It is tested to work in the development env with a couple of simple
helloworld.shandhelloworld2.shscripts plus a minimalmotd.patch. For production use it is recommended to instead use a numbering prefix for explicit ordering in order to assure patches and scripts are run in the expected order. E.g.00-initial-changes.patch, ...,42-fix-something-else.patch, ...,99-final-wrap-up.patchand similar for the scripts.Executed scripts and applied patches get registered in
/tmpin order to skip them and only run newly added ones ifapply-hotfixes.shis re-run inside the containers.NB: scripts need to be executable and patches need to be made with absolute path so that
patch -d / -p 0 < PATCHwill apply them cleanly without interaction.