Skip to content

Conversation

@keitaroemotion
Copy link

Currently, ruby-gpgme's set_info contaminates the global gpg status. For example, if there are several gpg process running simultaneously, one gpg fails since the other deprives of the working repository.

Then I added a new interface called set_info_safe, which take context as an argument so that it does not harm the other gpg related processes.

@coveralls
Copy link

coveralls commented Nov 24, 2017

Coverage Status

Coverage decreased (-0.2%) to 90.261% when pulling ef9f1d7 on keitaroemotion:add-non-intrusive-set-info into f70d026 on ueno:master.

@iwat
Copy link
Contributor

iwat commented Nov 24, 2017

Why don't you put that method to GPGME::Ctx class?

However, I'm surprised that gpgme_set_engine_info is already exposed.

@keitaroemotion
Copy link
Author

@chaiwat You're right. now it has been moved into Ctx na. Yes.... so maybe initially people tried to implemented it but turned out to be it was forgotten to implement... I assume....

@coveralls
Copy link

coveralls commented Nov 24, 2017

Coverage Status

Coverage decreased (-0.2%) to 90.261% when pulling be9e87b on keitaroemotion:add-non-intrusive-set-info into f70d026 on ueno:master.

@keitaroemotion
Copy link
Author

keitaroemotion commented Nov 24, 2017

@ueno Please merge this branch 🙇 お願いします

@djberg96
Copy link
Contributor

djberg96 commented Apr 7, 2025

Would recommend changing the name to set_engine_info. I don't think you need 'safely', it's understood to be happening at the context level since it's a context object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants