Skip to content

Conversation

@ice799
Copy link

@ice799 ice799 commented Jun 30, 2018

This change associates the buffer allocated in the gpgme_data write
callback with the UTF-8 encoding. If there is a configured internal
encoding (e.g. Encoding.default_internal), then the string is exported
to that encoding.

This change associates the buffer allocated in the gpgme_data write
callback with the UTF-8 encoding. If there is a configured internal
encoding (e.g. Encoding.default_internal), then the string is exported
to that encoding.
@ice799
Copy link
Author

ice799 commented Jun 30, 2018

This fixes this bug: #113

Probably would want to consider in the future unifying the encoding logic used in utf8_str_new and the logic added in this PR to work the same way -- users would probably be happy if they could set their own internal encoding that would affect both code paths.

@coveralls
Copy link

coveralls commented Jun 30, 2018

Coverage Status

Coverage increased (+0.06%) to 90.518% when pulling 5eb4513 on computology:utf8_cb into 387c775 on ueno:master.

@ice799
Copy link
Author

ice799 commented Jul 2, 2018

This fixes #113

@tommeier
Copy link

Hi 👋 any news on getting this merged in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants