Skip to content

Fix some warnings #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 8, 2025
Merged

Fix some warnings #195

merged 2 commits into from
Apr 8, 2025

Conversation

@djberg96
Copy link
Contributor

@djberg96 djberg96 commented Apr 7, 2025

Fixes a few long vs uint comparison warnings, removes one unused variable, and silences a couple ambiguity warnings from the tests.

ueno
ueno approved these changes Apr 8, 2025
View reviewed changes
Copy link
Owner

@ueno ueno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks; looks good to me. I wonder if NUM2INT might better suit for enum types, but gpg_error_t is defined to be non-negative, so that should be fine.

@ueno ueno merged commit 85c16a2 into ueno:master Apr 8, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ueno ueno ueno approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@djberg96 @ueno