Skip to content

Conversation

@JamieMagee
Copy link
Contributor

Changes I had to account for from gpgme:

  • Removed trust item functions
    • gpgme_op_trustlist_start, gpgme_op_tristlist_next, and gpgme_op_trustlist_end were removed
  • Removed GPGME_ATTR_* constants
  • Timestamp field type change
    • gpgme_subkey_t, gpgme_key_sig_t, and gpgme_new_signature_t changed from signed long to unsigned long
  • New functions
    • gpgme_op_random_bytes and gpgme_op_random_value
  • New constants
    • GPGME_RANDOM_MODE_NORMAL, GPGME_RANDOM_MODE_ZBASE32, GPGME_DECRYPT_LISTONLY, GPGME_CREATE_GROUP

Closes #202

- Bumped `gpgme` from `1.21.0` to `2.0.0`
  - https://github.com/gpg/gpgme/blob/master/NEWS
- Bumped `libassuan` from `2.5.6` to `3.0.2`
  - https://github.com/gpg/libassuan/blob/master/NEWS

Changes I had to account for from `gpgme`:
- Removed trust item functions
  - `gpgme_op_trustlist_start`, `gpgme_op_tristlist_next`, and `gpgme_op_trustlist_end` were removed
- Removed `GPGME_ATTR_*` constants
- Timestamp field type change
  - `gpgme_subkey_t`, `gpgme_key_sig_t`, and `gpgme_new_signature_t` changed from `signed long` to `unsigned long`
- New functions
  - `gpgme_op_random_bytes` and `gpgme_op_random_value`
- New constants
  - `GPGME_RANDOM_MODE_NORMAL`, `GPGME_RANDOM_MODE_ZBASE32`, `GPGME_DECRYPT_LISTONLY`, `GPGME_CREATE_GROUP`

Closes ueno#202
…ation

Change verify() to decrypt() for encrypted+signed data in two failing tests:

The tests were incorrectly calling verify() on data created with
crypto.encrypt(text, :sign => true), which produces encrypted+signed data.
The verify() method expects signed-only data, causing "Bad data" errors.

The decrypt() method properly handles both decryption and signature
verification for encrypted+signed data by calling ctx.decrypt_verify()
internally, then processing the embedded signatures.

This aligns with the existing pattern used in other working tests that
handle signed encrypted data.
@JamieMagee
Copy link
Contributor Author

@ueno could I get your review on this please?

Copy link
Owner

@ueno ueno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I didn't realize that 2.0.0 had an ABI bump; thank you so much for the rework for that. LGTM!

@ueno ueno merged commit 8695fec into ueno:master Jul 24, 2025
12 checks passed
@JamieMagee JamieMagee deleted the gpgme-2.0.0-libassuan-3.0.2 branch July 24, 2025 23:27
@JamieMagee
Copy link
Contributor Author

@ueno you're welcome. Are you able to tag and publish a release please?

@ueno
Copy link
Owner

ueno commented Jul 26, 2025

@ueno you're welcome. Are you able to tag and publish a release please?

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fails to build with gpgme >= 2.0.0

2 participants