-
Notifications
You must be signed in to change notification settings - Fork 101
Bump gpgme to 2.0.0 and libassuan to 3.0.2 #203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Bumped `gpgme` from `1.21.0` to `2.0.0` - https://github.com/gpg/gpgme/blob/master/NEWS - Bumped `libassuan` from `2.5.6` to `3.0.2` - https://github.com/gpg/libassuan/blob/master/NEWS Changes I had to account for from `gpgme`: - Removed trust item functions - `gpgme_op_trustlist_start`, `gpgme_op_tristlist_next`, and `gpgme_op_trustlist_end` were removed - Removed `GPGME_ATTR_*` constants - Timestamp field type change - `gpgme_subkey_t`, `gpgme_key_sig_t`, and `gpgme_new_signature_t` changed from `signed long` to `unsigned long` - New functions - `gpgme_op_random_bytes` and `gpgme_op_random_value` - New constants - `GPGME_RANDOM_MODE_NORMAL`, `GPGME_RANDOM_MODE_ZBASE32`, `GPGME_DECRYPT_LISTONLY`, `GPGME_CREATE_GROUP` Closes ueno#202
9df2b53 to
b3c76c0
Compare
…ation Change verify() to decrypt() for encrypted+signed data in two failing tests: The tests were incorrectly calling verify() on data created with crypto.encrypt(text, :sign => true), which produces encrypted+signed data. The verify() method expects signed-only data, causing "Bad data" errors. The decrypt() method properly handles both decryption and signature verification for encrypted+signed data by calling ctx.decrypt_verify() internally, then processing the embedded signatures. This aligns with the existing pattern used in other working tests that handle signed encrypted data.
|
@ueno could I get your review on this please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I didn't realize that 2.0.0 had an ABI bump; thank you so much for the rework for that. LGTM!
|
@ueno you're welcome. Are you able to tag and publish a release please? |
Done. |
gpgmefrom1.21.0to2.0.0libassuanfrom2.5.6to3.0.2Changes I had to account for from
gpgme:gpgme_op_trustlist_start,gpgme_op_tristlist_next, andgpgme_op_trustlist_endwere removedGPGME_ATTR_*constantsgpgme_subkey_t,gpgme_key_sig_t, andgpgme_new_signature_tchanged fromsigned longtounsigned longgpgme_op_random_bytesandgpgme_op_random_valueGPGME_RANDOM_MODE_NORMAL,GPGME_RANDOM_MODE_ZBASE32,GPGME_DECRYPT_LISTONLY,GPGME_CREATE_GROUPCloses #202