Skip to content

First version of paper for joss #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open

First version of paper for joss #99

wants to merge 29 commits into from

Conversation

Sosnowsky
Copy link
Member

No description provided.

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.39%. Comparing base (3e4d1c1) to head (20b043b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #99   +/-   ##
=======================================
  Coverage   98.39%   98.39%           
=======================================
  Files           7        7           
  Lines         311      311           
  Branches       21       21           
=======================================
  Hits          306      306           
  Misses          5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@EmilyBourne EmilyBourne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some grammar comments as part of the ongoing reviews at: openjournals/joss-reviews#8032

Copy link

@andrewgiuliani andrewgiuliani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, well written and a nice code. I've included here a few minor suggested changes to the manuscript.

Sosnowsky and others added 6 commits May 20, 2025 13:22
Co-authored-by: Emily Bourne <louise.bourne@gmail.com>
Co-authored-by: Emily Bourne <louise.bourne@gmail.com>
Co-authored-by: Emily Bourne <louise.bourne@gmail.com>
Sosnowsky and others added 2 commits June 17, 2025 08:09
Co-authored-by: Emily Bourne <louise.bourne@gmail.com>
@andrewgiuliani
Copy link

the compiled PDF now has dashes in the below paragraph, did you mean for this?

image

@Sosnowsky
Copy link
Member Author

For some reason that had the right format when compiling locally, now fixed by my last commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants