-
Notifications
You must be signed in to change notification settings - Fork 2
First version of paper for joss #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #99 +/- ##
=======================================
Coverage 98.39% 98.39%
=======================================
Files 7 7
Lines 311 311
Branches 21 21
=======================================
Hits 306 306
Misses 5 5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some grammar comments as part of the ongoing reviews at: openjournals/joss-reviews#8032
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, well written and a nice code. I've included here a few minor suggested changes to the manuscript.
Co-authored-by: Emily Bourne <louise.bourne@gmail.com>
Co-authored-by: Emily Bourne <louise.bourne@gmail.com>
Co-authored-by: Emily Bourne <louise.bourne@gmail.com>
Co-authored-by: Emily Bourne <louise.bourne@gmail.com>
For some reason that had the right format when compiling locally, now fixed by my last commit. |
No description provided.