-
Notifications
You must be signed in to change notification settings - Fork 801
Added docs around IMemberPartialViewCacheInvalidator #7133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have suggested changes on the 13 - if you agree and accept them, they should be applied to the 16 one too.
Also needs a link added to the landing page at https://docs.umbraco.com/umbraco-cms/reference/cache
And a link added to the SUMMARY.md
file.
13/umbraco-cms/reference/cache/imemberpartialviewcacheinvalidator.md
Outdated
Show resolved
Hide resolved
13/umbraco-cms/reference/cache/imemberpartialviewcacheinvalidator.md
Outdated
Show resolved
Hide resolved
13/umbraco-cms/reference/cache/imemberpartialviewcacheinvalidator.md
Outdated
Show resolved
Hide resolved
13/umbraco-cms/reference/cache/imemberpartialviewcacheinvalidator.md
Outdated
Show resolved
Hide resolved
13/umbraco-cms/reference/cache/imemberpartialviewcacheinvalidator.md
Outdated
Show resolved
Hide resolved
13/umbraco-cms/reference/cache/imemberpartialviewcacheinvalidator.md
Outdated
Show resolved
Hide resolved
13/umbraco-cms/reference/cache/imemberpartialviewcacheinvalidator.md
Outdated
Show resolved
Hide resolved
13/umbraco-cms/reference/cache/imemberpartialviewcacheinvalidator.md
Outdated
Show resolved
Hide resolved
13/umbraco-cms/reference/cache/imemberpartialviewcacheinvalidator.md
Outdated
Show resolved
Hide resolved
13/umbraco-cms/reference/cache/imemberpartialviewcacheinvalidator.md
Outdated
Show resolved
Hide resolved
Hey @Migaroez 👋 Do we have a date for when this PR is scheduled to be merged? Additionally, have you had a chance to review @AndyButland's's comments and suggestions? If you need assistance in addressing them, let me know, and I'll be happy to help. |
Co-authored-by: Andy Butland <abutland73@gmail.com>
Hey @eshanrnh, sorry for the delay. I have been head deep in bughunting the last few weeks. I have applied Andy's changes. If the docs team is happy with the state of the PR it can be merged in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries, @Migaroez 🙌 I have added a couple of suggestions to fix the value errors by writing shorter sentences.
16/umbraco-cms/reference/cache/imemberpartialviewcacheinvalidator.md
Outdated
Show resolved
Hide resolved
16/umbraco-cms/reference/cache/imemberpartialviewcacheinvalidator.md
Outdated
Show resolved
Hide resolved
13/umbraco-cms/reference/cache/imemberpartialviewcacheinvalidator.md
Outdated
Show resolved
Hide resolved
16/umbraco-cms/reference/cache/imemberpartialviewcacheinvalidator.md
Outdated
Show resolved
Hide resolved
16/umbraco-cms/reference/cache/imemberpartialviewcacheinvalidator.md
Outdated
Show resolved
Hide resolved
16/umbraco-cms/reference/cache/imemberpartialviewcacheinvalidator.md
Outdated
Show resolved
Hide resolved
16/umbraco-cms/reference/cache/imemberpartialviewcacheinvalidator.md
Outdated
Show resolved
Hide resolved
16/umbraco-cms/reference/cache/imemberpartialviewcacheinvalidator.md
Outdated
Show resolved
Hide resolved
16/umbraco-cms/reference/cache/imemberpartialviewcacheinvalidator.md
Outdated
Show resolved
Hide resolved
16/umbraco-cms/reference/cache/imemberpartialviewcacheinvalidator.md
Outdated
Show resolved
Hide resolved
16/umbraco-cms/reference/cache/imemberpartialviewcacheinvalidator.md
Outdated
Show resolved
Hide resolved
16/umbraco-cms/reference/cache/imemberpartialviewcacheinvalidator.md
Outdated
Show resolved
Hide resolved
13/umbraco-cms/reference/cache/imemberpartialviewcacheinvalidator.md
Outdated
Show resolved
Hide resolved
13/umbraco-cms/reference/cache/imemberpartialviewcacheinvalidator.md
Outdated
Show resolved
Hide resolved
16/umbraco-cms/reference/cache/imemberpartialviewcacheinvalidator.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Migaroez I have implemented Andy's suggestion in the v16 file to ensure that both versions contain the same content.
Could you add these new articles to theSummary.md
file for both v13 and v16 so that it shows in the navigation on the Docs site?
|
||
## Why do we need to partially invalidate the partial view cache? | ||
|
||
Razor templates showing data retrieved from a member object can be cached as partial views via: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is incomplete. Can you update it for both v13 and v16?
📋 Description
New Documentation regarding the new IMemberPartialViewCacheInvalidator introduced in
umbraco/Umbraco-CMS#19314 and umbraco/Umbraco-CMS#19459
✅ Contributor Checklist
I've followed the Umbraco Documentation Style Guide and can confirm that:
Product & Version (if relevant)
Umbraco CMS 13.9+ and 16.1+
Deadline (if relevant)
13.9 & 16.1
📚 Helpful Resources