Skip to content

Don't log misleading errors when the client closes a connection #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2025
Merged

Don't log misleading errors when the client closes a connection #585

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions Sources/PostgresNIO/New/PostgresChannelHandler.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -567,8 +567,13 @@ final class PostgresChannelHandler: ChannelDuplexHandler {
_ cleanup: ConnectionStateMachine.ConnectionAction.CleanUpContext,
context: ChannelHandlerContext
) {
self.logger.debug("Cleaning up and closing connection.", metadata: [.error: "\(cleanup.error)"])

// Don't log a misleading error if the client closed the connection.
if cleanup.error.code == .clientClosedConnection {
self.logger.debug("Cleaning up and closing connection.")
} else {
self.logger.debug("Cleaning up and closing connection.", metadata: [.error: "\(cleanup.error)"])
}

// 1. fail all tasks
cleanup.tasks.forEach { task in
task.failWithError(cleanup.error)
Expand Down