Re-enable legacyBehavior and passHref on Link #84500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unstubbable
reviewed
Oct 3, 2025
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
CodSpeed Performance ReportMerging #84500 will improve performances by 3.28%Comparing Summary
Benchmarks breakdown
Footnotes
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
samselikoff
force-pushed
the
reenable-legacy-behavior-link
branch
from
7d35ba0 to
0f10127
Compare
gnoff
reviewed
Oct 7, 2025
samselikoff
force-pushed
the
reenable-legacy-behavior-link
branch
2 times, most recently
from
34fa601 to
e5ffbfc
Compare
Stats from current PRDefault Build (Increase detected
|
| vercel/next.js canary | vercel/next.js reenable-legacy-behavior-link | Change | |
|---|---|---|---|
| buildDuration | 28.1s | 24.5s | N/A |
| buildDurationCached | 22.4s | 18.4s | N/A |
| nodeModulesSize | 450 MB | 450 MB | |
| nextStartRea..uration (ms) | 772ms | 699ms | N/A |
Client Bundles (main, webpack)
| vercel/next.js canary | vercel/next.js reenable-legacy-behavior-link | Change | |
|---|---|---|---|
| 1916.HASH.js gzip | 169 B | 169 B | ✓ |
| 4498-HASH.js gzip | 53.9 kB | 53.6 kB | N/A |
| 9225-HASH.js gzip | 5.19 kB | 5.18 kB | N/A |
| c57d0559-HASH.js gzip | 62 kB | 62 kB | N/A |
| framework-HASH.js gzip | 59.8 kB | 59.8 kB | ✓ |
| main-app-HASH.js gzip | 257 B | 256 B | N/A |
| main-HASH.js gzip | 36.3 kB | 36.2 kB | N/A |
| webpack-HASH.js gzip | 1.69 kB | 1.69 kB | N/A |
| Overall change | 60 kB | 60 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | vercel/next.js reenable-legacy-behavior-link | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 39.4 kB | 39.4 kB | ✓ |
| Overall change | 39.4 kB | 39.4 kB | ✓ |
Client Pages Overall increase ⚠️
| vercel/next.js canary | vercel/next.js reenable-legacy-behavior-link | Change | |
|---|---|---|---|
| _app-HASH.js gzip | 193 B | 193 B | ✓ |
| _error-HASH.js gzip | 182 B | 182 B | ✓ |
| css-HASH.js gzip | 334 B | 334 B | ✓ |
| dynamic-HASH.js gzip | 1.8 kB | 1.79 kB | N/A |
| edge-ssr-HASH.js gzip | 256 B | 255 B | N/A |
| head-HASH.js gzip | 350 B | 352 B | N/A |
| hooks-HASH.js gzip | 384 B | 381 B | N/A |
| image-HASH.js gzip | 4.67 kB | 4.66 kB | N/A |
| index-HASH.js gzip | 259 B | 260 B | N/A |
| link-HASH.js gzip | 2.28 kB | 2.51 kB | |
| routerDirect..HASH.js gzip | 318 B | 317 B | N/A |
| script-HASH.js gzip | 386 B | 386 B | ✓ |
| withRouter-HASH.js gzip | 315 B | 315 B | ✓ |
| 1afbb74e6ecf..834.css gzip | 106 B | 106 B | ✓ |
| Overall change | 3.79 kB | 4.03 kB |
Client Build Manifests
| vercel/next.js canary | vercel/next.js reenable-legacy-behavior-link | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 716 B | 718 B | N/A |
| Overall change | 0 B | 0 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | vercel/next.js reenable-legacy-behavior-link | Change | |
|---|---|---|---|
| index.html gzip | 524 B | 522 B | N/A |
| link.html gzip | 537 B | 538 B | N/A |
| withRouter.html gzip | 519 B | 519 B | ✓ |
| Overall change | 519 B | 519 B | ✓ |
Edge SSR bundle Size Overall increase ⚠️
| vercel/next.js canary | vercel/next.js reenable-legacy-behavior-link | Change | |
|---|---|---|---|
| edge-ssr.js gzip | 128 kB | 129 kB | |
| page.js gzip | 253 kB | 254 kB | |
| Overall change | 382 kB | 383 kB |
Middleware size
| vercel/next.js canary | vercel/next.js reenable-legacy-behavior-link | Change | |
|---|---|---|---|
| middleware-b..fest.js gzip | 636 B | 640 B | N/A |
| middleware-r..fest.js gzip | 156 B | 157 B | N/A |
| middleware.js gzip | 33.1 kB | 32.9 kB | N/A |
| edge-runtime..pack.js gzip | 846 B | 846 B | ✓ |
| Overall change | 846 B | 846 B | ✓ |
Next Runtimes
| vercel/next.js canary | vercel/next.js reenable-legacy-behavior-link | Change | |
|---|---|---|---|
| app-page-exp...dev.js gzip | 288 kB | 288 kB | N/A |
| app-page-exp..prod.js gzip | 158 kB | 158 kB | ✓ |
| app-page-tur...dev.js gzip | 288 kB | 288 kB | N/A |
| app-page-tur..prod.js gzip | 158 kB | 158 kB | ✓ |
| app-page-tur...dev.js gzip | 284 kB | 284 kB | ✓ |
| app-page-tur..prod.js gzip | 156 kB | 156 kB | ✓ |
| app-page.run...dev.js gzip | 284 kB | 284 kB | ✓ |
| app-page.run..prod.js gzip | 156 kB | 156 kB | ✓ |
| app-route-ex...dev.js gzip | 70.2 kB | 70.2 kB | ✓ |
| app-route-ex..prod.js gzip | 49.3 kB | 49.3 kB | ✓ |
| app-route-tu...dev.js gzip | 70.2 kB | 70.2 kB | ✓ |
| app-route-tu..prod.js gzip | 49.4 kB | 49.4 kB | ✓ |
| app-route-tu...dev.js gzip | 69.8 kB | 69.8 kB | ✓ |
| app-route-tu..prod.js gzip | 49.1 kB | 49.1 kB | ✓ |
| app-route.ru...dev.js gzip | 69.8 kB | 69.8 kB | ✓ |
| app-route.ru..prod.js gzip | 49.1 kB | 49.1 kB | ✓ |
| dist_client_...dev.js gzip | 326 B | 326 B | ✓ |
| dist_client_...dev.js gzip | 328 B | 328 B | ✓ |
| dist_client_...dev.js gzip | 320 B | 320 B | ✓ |
| dist_client_...dev.js gzip | 318 B | 318 B | ✓ |
| pages-api-tu...dev.js gzip | 43.1 kB | 43.1 kB | ✓ |
| pages-api-tu..prod.js gzip | 33.1 kB | 33.1 kB | ✓ |
| pages-api.ru...dev.js gzip | 43 kB | 43 kB | ✓ |
| pages-api.ru..prod.js gzip | 33.1 kB | 33.1 kB | ✓ |
| pages-turbo....dev.js gzip | 52.8 kB | 52.8 kB | ✓ |
| pages-turbo...prod.js gzip | 40.2 kB | 40.2 kB | ✓ |
| pages.runtim...dev.js gzip | 52.8 kB | 52.8 kB | ✓ |
| pages.runtim..prod.js gzip | 40.2 kB | 40.2 kB | ✓ |
| server.runti..prod.js gzip | 79.2 kB | 79.2 kB | ✓ |
| Overall change | 2.09 MB | 2.09 MB | ✓ |
build cache Overall increase ⚠️
| vercel/next.js canary | vercel/next.js reenable-legacy-behavior-link | Change | |
|---|---|---|---|
| 0.pack gzip | 3.07 MB | 3.08 MB | |
| index.pack gzip | 92.3 kB | 92.4 kB | N/A |
| Overall change | 3.07 MB | 3.08 MB |
Diff details
Diff for page.js
Diff too large to display
Diff for middleware.js
Diff too large to display
Diff for edge-ssr.js
Diff too large to display
Diff for css-HASH.js
@@ -1,7 +1,31 @@
(self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
[9813],
{
- /***/ 3593: /***/ (
+ /***/ 5832: /***/ (module) => {
+ // extracted by mini-css-extract-plugin
+ module.exports = { helloWorld: "css_helloWorld__aUdUq" };
+
+ /***/
+ },
+
+ /***/ 6471: /***/ (
+ __unused_webpack_module,
+ __unused_webpack_exports,
+ __webpack_require__
+ ) => {
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/css",
+ function () {
+ return __webpack_require__(7839);
+ },
+ ]);
+ if (false) {
+ }
+
+ /***/
+ },
+
+ /***/ 7839: /***/ (
__unused_webpack_module,
__webpack_exports__,
__webpack_require__
@@ -15,7 +39,7 @@
/* harmony import */ var react_jsx_runtime__WEBPACK_IMPORTED_MODULE_0__ =
__webpack_require__(1503);
/* harmony import */ var _css_module_css__WEBPACK_IMPORTED_MODULE_1__ =
- __webpack_require__(7634);
+ __webpack_require__(5832);
/* harmony import */ var _css_module_css__WEBPACK_IMPORTED_MODULE_1___default =
/*#__PURE__*/ __webpack_require__.n(
_css_module_css__WEBPACK_IMPORTED_MODULE_1__
@@ -34,37 +58,13 @@
/***/
},
-
- /***/ 4569: /***/ (
- __unused_webpack_module,
- __unused_webpack_exports,
- __webpack_require__
- ) => {
- (window.__NEXT_P = window.__NEXT_P || []).push([
- "/css",
- function () {
- return __webpack_require__(3593);
- },
- ]);
- if (false) {
- }
-
- /***/
- },
-
- /***/ 7634: /***/ (module) => {
- // extracted by mini-css-extract-plugin
- module.exports = { helloWorld: "css_helloWorld__aUdUq" };
-
- /***/
- },
},
/******/ (__webpack_require__) => {
// webpackRuntimeModules
/******/ var __webpack_exec__ = (moduleId) =>
__webpack_require__((__webpack_require__.s = moduleId));
/******/ __webpack_require__.O(0, [636, 6593, 8792], () =>
- __webpack_exec__(4569)
+ __webpack_exec__(6471)
);
/******/ var __webpack_exports__ = __webpack_require__.O();
/******/ _N_E = __webpack_exports__;Diff for dynamic-HASH.js
@@ -1,24 +1,7 @@
(self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
[2291],
{
- /***/ 1033: /***/ (
- __unused_webpack_module,
- __unused_webpack_exports,
- __webpack_require__
- ) => {
- (window.__NEXT_P = window.__NEXT_P || []).push([
- "/dynamic",
- function () {
- return __webpack_require__(2283);
- },
- ]);
- if (false) {
- }
-
- /***/
- },
-
- /***/ 2283: /***/ (
+ /***/ 133: /***/ (
__unused_webpack_module,
__webpack_exports__,
__webpack_require__
@@ -33,7 +16,7 @@
/* harmony import */ var react_jsx_runtime__WEBPACK_IMPORTED_MODULE_0__ =
__webpack_require__(1503);
/* harmony import */ var next_dynamic__WEBPACK_IMPORTED_MODULE_1__ =
- __webpack_require__(4939);
+ __webpack_require__(7514);
/* harmony import */ var next_dynamic__WEBPACK_IMPORTED_MODULE_1___default =
/*#__PURE__*/ __webpack_require__.n(
next_dynamic__WEBPACK_IMPORTED_MODULE_1__
@@ -42,12 +25,12 @@
const DynamicHello = next_dynamic__WEBPACK_IMPORTED_MODULE_1___default()(
() =>
__webpack_require__
- .e(/* import() */ 1916)
- .then(__webpack_require__.bind(__webpack_require__, 1916))
+ .e(/* import() */ 3862)
+ .then(__webpack_require__.bind(__webpack_require__, 3862))
.then((mod) => mod.Hello),
{
loadableGenerated: {
- webpack: () => [/*require.resolve*/ 1916],
+ webpack: () => [/*require.resolve*/ 3862],
},
}
);
@@ -74,17 +57,24 @@
/***/
},
- /***/ 4939: /***/ (
- module,
+ /***/ 431: /***/ (
+ __unused_webpack_module,
__unused_webpack_exports,
__webpack_require__
) => {
- module.exports = __webpack_require__(5121);
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/dynamic",
+ function () {
+ return __webpack_require__(133);
+ },
+ ]);
+ if (false) {
+ }
/***/
},
- /***/ 5121: /***/ (module, exports, __webpack_require__) => {
+ /***/ 1709: /***/ (module, exports, __webpack_require__) => {
"use strict";
Object.defineProperty(exports, "__esModule", {
@@ -117,7 +107,7 @@
__webpack_require__(2223)
);
const _loadablesharedruntime = /*#__PURE__*/ _interop_require_default._(
- __webpack_require__(7622)
+ __webpack_require__(2522)
);
const isServerSide = "object" === "undefined";
// Normalize loader to return the module as form { default: Component } for `React.lazy`.
@@ -217,34 +207,7 @@
/***/
},
- /***/ 5160: /***/ (
- __unused_webpack_module,
- exports,
- __webpack_require__
- ) => {
- "use strict";
- /* __next_internal_client_entry_do_not_use__ cjs */
- Object.defineProperty(exports, "__esModule", {
- value: true,
- });
- Object.defineProperty(exports, "LoadableContext", {
- enumerable: true,
- get: function () {
- return LoadableContext;
- },
- });
- const _interop_require_default = __webpack_require__(1532);
- const _react = /*#__PURE__*/ _interop_require_default._(
- __webpack_require__(2223)
- );
- const LoadableContext = _react.default.createContext(null);
- if (false) {
- } //# sourceMappingURL=loadable-context.shared-runtime.js.map
-
- /***/
- },
-
- /***/ 7622: /***/ (
+ /***/ 2522: /***/ (
__unused_webpack_module,
exports,
__webpack_require__
@@ -286,7 +249,7 @@ WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE
const _react = /*#__PURE__*/ _interop_require_default._(
__webpack_require__(2223)
);
- const _loadablecontextsharedruntime = __webpack_require__(5160);
+ const _loadablecontextsharedruntime = __webpack_require__(4844);
function resolve(obj) {
return obj && obj.default ? obj.default : obj;
}
@@ -519,13 +482,50 @@ WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE
/***/
},
+
+ /***/ 4844: /***/ (
+ __unused_webpack_module,
+ exports,
+ __webpack_require__
+ ) => {
+ "use strict";
+ /* __next_internal_client_entry_do_not_use__ cjs */
+ Object.defineProperty(exports, "__esModule", {
+ value: true,
+ });
+ Object.defineProperty(exports, "LoadableContext", {
+ enumerable: true,
+ get: function () {
+ return LoadableContext;
+ },
+ });
+ const _interop_require_default = __webpack_require__(1532);
+ const _react = /*#__PURE__*/ _interop_require_default._(
+ __webpack_require__(2223)
+ );
+ const LoadableContext = _react.default.createContext(null);
+ if (false) {
+ } //# sourceMappingURL=loadable-context.shared-runtime.js.map
+
+ /***/
+ },
+
+ /***/ 7514: /***/ (
+ module,
+ __unused_webpack_exports,
+ __webpack_require__
+ ) => {
+ module.exports = __webpack_require__(1709);
+
+ /***/
+ },
},
/******/ (__webpack_require__) => {
// webpackRuntimeModules
/******/ var __webpack_exec__ = (moduleId) =>
__webpack_require__((__webpack_require__.s = moduleId));
/******/ __webpack_require__.O(0, [636, 6593, 8792], () =>
- __webpack_exec__(1033)
+ __webpack_exec__(431)
);
/******/ var __webpack_exports__ = __webpack_require__.O();
/******/ _N_E = __webpack_exports__;Diff for hooks-HASH.js
@@ -1,24 +1,7 @@
(self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
[9804],
{
- /***/ 1679: /***/ (
- __unused_webpack_module,
- __unused_webpack_exports,
- __webpack_require__
- ) => {
- (window.__NEXT_P = window.__NEXT_P || []).push([
- "/hooks",
- function () {
- return __webpack_require__(9198);
- },
- ]);
- if (false) {
- }
-
- /***/
- },
-
- /***/ 9198: /***/ (
+ /***/ 2592: /***/ (
__unused_webpack_module,
__webpack_exports__,
__webpack_require__
@@ -76,13 +59,30 @@
/***/
},
+
+ /***/ 3925: /***/ (
+ __unused_webpack_module,
+ __unused_webpack_exports,
+ __webpack_require__
+ ) => {
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/hooks",
+ function () {
+ return __webpack_require__(2592);
+ },
+ ]);
+ if (false) {
+ }
+
+ /***/
+ },
},
/******/ (__webpack_require__) => {
// webpackRuntimeModules
/******/ var __webpack_exec__ = (moduleId) =>
__webpack_require__((__webpack_require__.s = moduleId));
/******/ __webpack_require__.O(0, [636, 6593, 8792], () =>
- __webpack_exec__(1679)
+ __webpack_exec__(3925)
);
/******/ var __webpack_exports__ = __webpack_require__.O();
/******/ _N_E = __webpack_exports__;Diff for image-HASH.js
Diff too large to display
Diff for index-HASH.js
@@ -1,7 +1,24 @@
(self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
[3332],
{
- /***/ 3454: /***/ (
+ /***/ 8431: /***/ (
+ __unused_webpack_module,
+ __unused_webpack_exports,
+ __webpack_require__
+ ) => {
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/",
+ function () {
+ return __webpack_require__(8972);
+ },
+ ]);
+ if (false) {
+ }
+
+ /***/
+ },
+
+ /***/ 8972: /***/ (
__unused_webpack_module,
__webpack_exports__,
__webpack_require__
@@ -19,30 +36,13 @@
/***/
},
-
- /***/ 9241: /***/ (
- __unused_webpack_module,
- __unused_webpack_exports,
- __webpack_require__
- ) => {
- (window.__NEXT_P = window.__NEXT_P || []).push([
- "/",
- function () {
- return __webpack_require__(3454);
- },
- ]);
- if (false) {
- }
-
- /***/
- },
},
/******/ (__webpack_require__) => {
// webpackRuntimeModules
/******/ var __webpack_exec__ = (moduleId) =>
__webpack_require__((__webpack_require__.s = moduleId));
/******/ __webpack_require__.O(0, [636, 6593, 8792], () =>
- __webpack_exec__(9241)
+ __webpack_exec__(8431)
);
/******/ var __webpack_exports__ = __webpack_require__.O();
/******/ _N_E = __webpack_exports__;Diff for link-HASH.js
@@ -1,7 +1,24 @@
(self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
[4672],
{
- /***/ 3262: /***/ (module, exports, __webpack_require__) => {
+ /***/ 2025: /***/ (
+ __unused_webpack_module,
+ __unused_webpack_exports,
+ __webpack_require__
+ ) => {
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/link",
+ function () {
+ return __webpack_require__(3072);
+ },
+ ]);
+ if (false) {
+ }
+
+ /***/
+ },
+
+ /***/ 3066: /***/ (module, exports, __webpack_require__) => {
"use strict";
/* __next_internal_client_entry_do_not_use__ cjs */
Object.defineProperty(exports, "__esModule", {
@@ -28,16 +45,17 @@
const _react = /*#__PURE__*/ _interop_require_wildcard._(
__webpack_require__(2223)
);
- const _resolvehref = __webpack_require__(7868);
- const _islocalurl = __webpack_require__(9350);
- const _formaturl = __webpack_require__(6319);
- const _utils = __webpack_require__(9889);
- const _addlocale = __webpack_require__(9466);
- const _routercontextsharedruntime = __webpack_require__(5691);
- const _useintersection = __webpack_require__(3981);
- const _getdomainlocale = __webpack_require__(4206);
- const _addbasepath = __webpack_require__(9339);
- const _usemergedref = __webpack_require__(6848);
+ const _resolvehref = __webpack_require__(2776);
+ const _islocalurl = __webpack_require__(5770);
+ const _formaturl = __webpack_require__(8531);
+ const _utils = __webpack_require__(3565);
+ const _addlocale = __webpack_require__(8878);
+ const _routercontextsharedruntime = __webpack_require__(5111);
+ const _useintersection = __webpack_require__(6873);
+ const _getdomainlocale = __webpack_require__(4554);
+ const _addbasepath = __webpack_require__(9567);
+ const _usemergedref = __webpack_require__(4308);
+ const _erroronce = __webpack_require__(8910);
const prefetched = new Set();
function prefetch(router, href, as, options) {
if (false) {
@@ -94,7 +112,13 @@
locale,
onNavigate
) {
- if (isModifiedEvent(e) || e.currentTarget.hasAttribute("download")) {
+ const { nodeName } = e.currentTarget;
+ // anchors inside an svg have a lowercase nodeName
+ const isAnchorNodeName = nodeName.toUpperCase() === "A";
+ if (
+ (isAnchorNodeName && isModifiedEvent(e)) ||
+ e.currentTarget.hasAttribute("download")
+ ) {
// ignore click for browser’s default behavior
return;
}
@@ -152,11 +176,13 @@
* Read more: [Next.js docs: `<Link>`](https://nextjs.org/docs/app/api-reference/components/link)
*/ const Link = /*#__PURE__*/ _react.default.forwardRef(
function LinkComponent(props, forwardedRef) {
+ let children;
const {
href: hrefProp,
as: asProp,
- children,
+ children: childrenProp,
prefetch: prefetchProp = null,
+ passHref,
replace,
shallow,
scroll,
@@ -165,8 +191,18 @@
onNavigate,
onMouseEnter: onMouseEnterProp,
onTouchStart: onTouchStartProp,
+ legacyBehavior = false,
...restProps
} = props;
+ children = childrenProp;
+ if (
+ legacyBehavior &&
+ (typeof children === "string" || typeof children === "number")
+ ) {
+ children = /*#__PURE__*/ (0, _jsxruntime.jsx)("a", {
+ children: children,
+ });
+ }
const router = _react.default.useContext(
_routercontextsharedruntime.RouterContext
);
@@ -195,8 +231,20 @@
}, [router, hrefProp, asProp]);
const previousHref = _react.default.useRef(href);
const previousAs = _react.default.useRef(as);
- if (false) {
+ // This will return the first child, if multiple are provided it will throw an error
+ let child;
+ if (legacyBehavior) {
+ if (false) {
+ } else {
+ child = _react.default.Children.only(children);
+ }
+ } else {
+ if (false) {
+ }
}
+ const childRef = legacyBehavior
+ ? child && typeof child === "object" && child.ref
+ : forwardedRef;
const [setIntersectionRef, isVisible, resetVisible] = (0,
_useintersection.useIntersection)({
rootMargin: "200px",
@@ -215,7 +263,7 @@
);
const setRef = (0, _usemergedref.useMergedRef)(
setIntersectionWithResetRef,
- forwardedRef
+ childRef
);
// Prefetch the URL if we haven't already and it's visible.
_react.default.useEffect(() => {
@@ -242,12 +290,21 @@
router?.locale,
router,
]);
- const anchorProps = {
+ const childProps = {
ref: setRef,
onClick(e) {
- if (typeof onClick === "function") {
+ if (false) {
+ }
+ if (!legacyBehavior && typeof onClick === "function") {
onClick(e);
}
+ if (
+ legacyBehavior &&
+ child.props &&
+ typeof child.props.onClick === "function"
+ ) {
+ child.props.onClick(e);
+ }
if (!router) {
return;
}
@@ -267,9 +324,16 @@
);
},
onMouseEnter(e) {
- if (typeof onMouseEnterProp === "function") {
+ if (!legacyBehavior && typeof onMouseEnterProp === "function") {
onMouseEnterProp(e);
}
+ if (
+ legacyBehavior &&
+ child.props &&
+ typeof child.props.onMouseEnter === "function"
+ ) {
+ child.props.onMouseEnter(e);
+ }
if (!router) {
return;
}
@@ -283,9 +347,19 @@
onTouchStart: false
? 0
: function onTouchStart(e) {
- if (typeof onTouchStartProp === "function") {
+ if (
+ !legacyBehavior &&
+ typeof onTouchStartProp === "function"
+ ) {
onTouchStartProp(e);
}
+ if (
+ legacyBehavior &&
+ child.props &&
+ typeof child.props.onTouchStart === "function"
+ ) {
+ child.props.onTouchStart(e);
+ }
if (!router) {
return;
}
@@ -299,8 +373,12 @@
};
// If the url is absolute, we can bypass the logic to prepend the domain and locale.
if ((0, _utils.isAbsoluteUrl)(as)) {
- anchorProps.href = as;
- } else {
+ childProps.href = as;
+ } else if (
+ !legacyBehavior ||
+ passHref ||
+ (child.type === "a" && !("href" in child.props))
+ ) {
const curLocale =
typeof locale !== "undefined" ? locale : router?.locale;
// we only render domain locales if we are currently on a domain locale
@@ -313,15 +391,20 @@
router?.locales,
router?.domainLocales
);
- anchorProps.href =
+ childProps.href =
localeDomain ||
(0, _addbasepath.addBasePath)(
(0, _addlocale.addLocale)(as, curLocale, router?.defaultLocale)
);
}
+ if (legacyBehavior) {
+ if (false) {
+ }
+ return /*#__PURE__*/ _react.default.cloneElement(child, childProps);
+ }
return /*#__PURE__*/ (0, _jsxruntime.jsx)("a", {
...restProps,
- ...anchorProps,
+ ...childProps,
children: children,
});
}
@@ -351,7 +434,167 @@
/***/
},
- /***/ 3981: /***/ (module, exports, __webpack_require__) => {
+ /***/ 3072: /***/ (
+ __unused_webpack_module,
+ __webpack_exports__,
+ __webpack_require__
+ ) => {
+ "use strict";
+ __webpack_require__.r(__webpack_exports__);
+ /* harmony export */ __webpack_require__.d(__webpack_exports__, {
+ /* harmony export */ __N_SSP: () => /* binding */ __N_SSP,
+ /* harmony export */ default: () => __WEBPACK_DEFAULT_EXPORT__,
+ /* harmony export */
+ });
+ /* harmony import */ var react_jsx_runtime__WEBPACK_IMPORTED_MODULE_0__ =
+ __webpack_require__(1503);
+ /* harmony import */ var next_link__WEBPACK_IMPORTED_MODULE_1__ =
+ __webpack_require__(6929);
+ /* harmony import */ var next_link__WEBPACK_IMPORTED_MODULE_1___default =
+ /*#__PURE__*/ __webpack_require__.n(
+ next_link__WEBPACK_IMPORTED_MODULE_1__
+ );
+
+ function aLink(props) {
+ return /*#__PURE__*/ (0,
+ react_jsx_runtime__WEBPACK_IMPORTED_MODULE_0__.jsxs)("div", {
+ children: [
+ /*#__PURE__*/ (0,
+ react_jsx_runtime__WEBPACK_IMPORTED_MODULE_0__.jsx)("h3", {
+ children: "A Link page!",
+ }),
+ /*#__PURE__*/ (0,
+ react_jsx_runtime__WEBPACK_IMPORTED_MODULE_0__.jsx)(
+ next_link__WEBPACK_IMPORTED_MODULE_1___default(),
+ {
+ href: "/",
+ children: "Go to /",
+ }
+ ),
+ ],
+ });
+ }
+ var __N_SSP = true;
+ /* harmony default export */ const __WEBPACK_DEFAULT_EXPORT__ = aLink;
+
+ /***/
+ },
+
+ /***/ 4308: /***/ (module, exports, __webpack_require__) => {
+ "use strict";
+
+ Object.defineProperty(exports, "__esModule", {
+ value: true,
+ });
+ Object.defineProperty(exports, "useMergedRef", {
+ enumerable: true,
+ get: function () {
+ return useMergedRef;
+ },
+ });
+ const _react = __webpack_require__(2223);
+ function useMergedRef(refA, refB) {
+ const cleanupA = (0, _react.useRef)(null);
+ const cleanupB = (0, _react.useRef)(null);
+ // NOTE: In theory, we could skip the wrapping if only one of the refs is non-null.
+ // (this happens often if the user doesn't pass a ref to Link/Form/Image)
+ // But this can cause us to leak a cleanup-ref into user code (previously via `<Link legacyBehavior>`),
+ // and the user might pass that ref into ref-merging library that doesn't support cleanup refs
+ // (because it hasn't been updated for React 19)
+ // which can then cause things to blow up, because a cleanup-returning ref gets called with `null`.
+ // So in practice, it's safer to be defensive and always wrap the ref, even on React 19.
+ return (0, _react.useCallback)(
+ (current) => {
+ if (current === null) {
+ const cleanupFnA = cleanupA.current;
+ if (cleanupFnA) {
+ cleanupA.current = null;
+ cleanupFnA();
+ }
+ const cleanupFnB = cleanupB.current;
+ if (cleanupFnB) {
+ cleanupB.current = null;
+ cleanupFnB();
+ }
+ } else {
+ if (refA) {
+ cleanupA.current = applyRef(refA, current);
+ }
+ if (refB) {
+ cleanupB.current = applyRef(refB, current);
+ }
+ }
+ },
+ [refA, refB]
+ );
+ }
+ function applyRef(refA, current) {
+ if (typeof refA === "function") {
+ const cleanup = refA(current);
+ if (typeof cleanup === "function") {
+ return cleanup;
+ } else {
+ return () => refA(null);
+ }
+ } else {
+ refA.current = current;
+ return () => {
+ refA.current = null;
+ };
+ }
+ }
+ if (
+ (typeof exports.default === "function" ||
+ (typeof exports.default === "object" && exports.default !== null)) &&
+ typeof exports.default.__esModule === "undefined"
+ ) {
+ Object.defineProperty(exports.default, "__esModule", {
+ value: true,
+ });
+ Object.assign(exports.default, exports);
+ module.exports = exports.default;
+ } //# sourceMappingURL=use-merged-ref.js.map
+
+ /***/
+ },
+
+ /***/ 4554: /***/ (module, exports, __webpack_require__) => {
+ "use strict";
+
+ Object.defineProperty(exports, "__esModule", {
+ value: true,
+ });
+ Object.defineProperty(exports, "getDomainLocale", {
+ enumerable: true,
+ get: function () {
+ return getDomainLocale;
+ },
+ });
+ const _normalizetrailingslash = __webpack_require__(7740);
+ const basePath =
+ /* unused pure expression or super */ null && (false || "");
+ function getDomainLocale(path, locale, locales, domainLocales) {
+ if (false) {
+ } else {
+ return false;
+ }
+ }
+ if (
+ (typeof exports.default === "function" ||
+ (typeof exports.default === "object" && exports.default !== null)) &&
+ typeof exports.default.__esModule === "undefined"
+ ) {
+ Object.defineProperty(exports.default, "__esModule", {
+ value: true,
+ });
+ Object.assign(exports.default, exports);
+ module.exports = exports.default;
+ } //# sourceMappingURL=get-domain-locale.js.map
+
+ /***/
+ },
+
+ /***/ 6873: /***/ (module, exports, __webpack_require__) => {
"use strict";
Object.defineProperty(exports, "__esModule", {
@@ -364,7 +607,7 @@
},
});
const _react = __webpack_require__(2223);
- const _requestidlecallback = __webpack_require__(1472);
+ const _requestidlecallback = __webpack_require__(6892);
const hasIntersectionObserver =
typeof IntersectionObserver === "function";
const observers = new Map();
@@ -476,189 +719,31 @@
/***/
},
- /***/ 4206: /***/ (module, exports, __webpack_require__) => {
- "use strict";
-
- Object.defineProperty(exports, "__esModule", {
- value: true,
- });
- Object.defineProperty(exports, "getDomainLocale", {
- enumerable: true,
- get: function () {
- return getDomainLocale;
- },
- });
- const _normalizetrailingslash = __webpack_require__(6704);
- const basePath =
- /* unused pure expression or super */ null && (false || "");
- function getDomainLocale(path, locale, locales, domainLocales) {
- if (false) {
- } else {
- return false;
- }
- }
- if (
- (typeof exports.default === "function" ||
- (typeof exports.default === "object" && exports.default !== null)) &&
- typeof exports.default.__esModule === "undefined"
- ) {
- Object.defineProperty(exports.default, "__esModule", {
- value: true,
- });
- Object.assign(exports.default, exports);
- module.exports = exports.default;
- } //# sourceMappingURL=get-domain-locale.js.map
-
- /***/
- },
-
- /***/ 6691: /***/ (
+ /***/ 6929: /***/ (
module,
__unused_webpack_exports,
__webpack_require__
) => {
- module.exports = __webpack_require__(3262);
-
- /***/
- },
-
- /***/ 6771: /***/ (
- __unused_webpack_module,
- __unused_webpack_exports,
- __webpack_require__
- ) => {
- (window.__NEXT_P = window.__NEXT_P || []).push([
- "/link",
- function () {
- return __webpack_require__(8178);
- },
- ]);
- if (false) {
- }
+ module.exports = __webpack_require__(3066);
/***/
},
- /***/ 6848: /***/ (module, exports, __webpack_require__) => {
+ /***/ 8910: /***/ (__unused_webpack_module, exports) => {
"use strict";
Object.defineProperty(exports, "__esModule", {
value: true,
});
- Object.defineProperty(exports, "useMergedRef", {
+ Object.defineProperty(exports, "errorOnce", {
enumerable: true,
get: function () {
- return useMergedRef;
+ return errorOnce;
},
});
- const _react = __webpack_require__(2223);
- function useMergedRef(refA, refB) {
- const cleanupA = (0, _react.useRef)(null);
- const cleanupB = (0, _react.useRef)(null);
- // NOTE: In theory, we could skip the wrapping if only one of the refs is non-null.
- // (this happens often if the user doesn't pass a ref to Link/Form/Image)
- // But this can cause us to leak a cleanup-ref into user code (previously via `<Link legacyBehavior>`),
- // and the user might pass that ref into ref-merging library that doesn't support cleanup refs
- // (because it hasn't been updated for React 19)
- // which can then cause things to blow up, because a cleanup-returning ref gets called with `null`.
- // So in practice, it's safer to be defensive and always wrap the ref, even on React 19.
- return (0, _react.useCallback)(
- (current) => {
- if (current === null) {
- const cleanupFnA = cleanupA.current;
- if (cleanupFnA) {
- cleanupA.current = null;
- cleanupFnA();
- }
- const cleanupFnB = cleanupB.current;
- if (cleanupFnB) {
- cleanupB.current = null;
- cleanupFnB();
- }
- } else {
- if (refA) {
- cleanupA.current = applyRef(refA, current);
- }
- if (refB) {
- cleanupB.current = applyRef(refB, current);
- }
- }
- },
- [refA, refB]
- );
- }
- function applyRef(refA, current) {
- if (typeof refA === "function") {
- const cleanup = refA(current);
- if (typeof cleanup === "function") {
- return cleanup;
- } else {
- return () => refA(null);
- }
- } else {
- refA.current = current;
- return () => {
- refA.current = null;
- };
- }
- }
- if (
- (typeof exports.default === "function" ||
- (typeof exports.default === "object" && exports.default !== null)) &&
- typeof exports.default.__esModule === "undefined"
- ) {
- Object.defineProperty(exports.default, "__esModule", {
- value: true,
- });
- Object.assign(exports.default, exports);
- module.exports = exports.default;
- } //# sourceMappingURL=use-merged-ref.js.map
-
- /***/
- },
-
- /***/ 8178: /***/ (
- __unused_webpack_module,
- __webpack_exports__,
- __webpack_require__
- ) => {
- "use strict";
- __webpack_require__.r(__webpack_exports__);
- /* harmony export */ __webpack_require__.d(__webpack_exports__, {
- /* harmony export */ __N_SSP: () => /* binding */ __N_SSP,
- /* harmony export */ default: () => __WEBPACK_DEFAULT_EXPORT__,
- /* harmony export */
- });
- /* harmony import */ var react_jsx_runtime__WEBPACK_IMPORTED_MODULE_0__ =
- __webpack_require__(1503);
- /* harmony import */ var next_link__WEBPACK_IMPORTED_MODULE_1__ =
- __webpack_require__(6691);
- /* harmony import */ var next_link__WEBPACK_IMPORTED_MODULE_1___default =
- /*#__PURE__*/ __webpack_require__.n(
- next_link__WEBPACK_IMPORTED_MODULE_1__
- );
-
- function aLink(props) {
- return /*#__PURE__*/ (0,
- react_jsx_runtime__WEBPACK_IMPORTED_MODULE_0__.jsxs)("div", {
- children: [
- /*#__PURE__*/ (0,
- react_jsx_runtime__WEBPACK_IMPORTED_MODULE_0__.jsx)("h3", {
- children: "A Link page!",
- }),
- /*#__PURE__*/ (0,
- react_jsx_runtime__WEBPACK_IMPORTED_MODULE_0__.jsx)(
- next_link__WEBPACK_IMPORTED_MODULE_1___default(),
- {
- href: "/",
- children: "Go to /",
- }
- ),
- ],
- });
- }
- var __N_SSP = true;
- /* harmony default export */ const __WEBPACK_DEFAULT_EXPORT__ = aLink;
+ let errorOnce = (_) => {};
+ if (false) {
+ } //# sourceMappingURL=error-once.js.map
/***/
},
@@ -668,7 +753,7 @@
/******/ var __webpack_exec__ = (moduleId) =>
__webpack_require__((__webpack_require__.s = moduleId));
/******/ __webpack_require__.O(0, [636, 6593, 8792], () =>
- __webpack_exec__(6771)
+ __webpack_exec__(2025)
);
/******/ var __webpack_exports__ = __webpack_require__.O();
/******/ _N_E = __webpack_exports__;Diff for routerDirect-HASH.js
@@ -1,7 +1,24 @@
(self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
[188],
{
- /***/ 286: /***/ (
+ /***/ 417: /***/ (
+ __unused_webpack_module,
+ __unused_webpack_exports,
+ __webpack_require__
+ ) => {
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/routerDirect",
+ function () {
+ return __webpack_require__(504);
+ },
+ ]);
+ if (false) {
+ }
+
+ /***/
+ },
+
+ /***/ 504: /***/ (
__unused_webpack_module,
__webpack_exports__,
__webpack_require__
@@ -16,7 +33,7 @@
/* harmony import */ var react_jsx_runtime__WEBPACK_IMPORTED_MODULE_0__ =
__webpack_require__(1503);
/* harmony import */ var next_router__WEBPACK_IMPORTED_MODULE_1__ =
- __webpack_require__(7798);
+ __webpack_require__(1840);
/* harmony import */ var next_router__WEBPACK_IMPORTED_MODULE_1___default =
/*#__PURE__*/ __webpack_require__.n(
next_router__WEBPACK_IMPORTED_MODULE_1__
@@ -36,29 +53,12 @@
/***/
},
- /***/ 4283: /***/ (
- __unused_webpack_module,
- __unused_webpack_exports,
- __webpack_require__
- ) => {
- (window.__NEXT_P = window.__NEXT_P || []).push([
- "/routerDirect",
- function () {
- return __webpack_require__(286);
- },
- ]);
- if (false) {
- }
-
- /***/
- },
-
- /***/ 7798: /***/ (
+ /***/ 1840: /***/ (
module,
__unused_webpack_exports,
__webpack_require__
) => {
- module.exports = __webpack_require__(9587);
+ module.exports = __webpack_require__(1903);
/***/
},
@@ -68,7 +68,7 @@
/******/ var __webpack_exec__ = (moduleId) =>
__webpack_require__((__webpack_require__.s = moduleId));
/******/ __webpack_require__.O(0, [636, 6593, 8792], () =>
- __webpack_exec__(4283)
+ __webpack_exec__(417)
);
/******/ var __webpack_exports__ = __webpack_require__.O();
/******/ _N_E = __webpack_exports__;Diff for script-HASH.js
@@ -1,7 +1,34 @@
(self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
[1209],
{
- /***/ 661: /***/ (
+ /***/ 2398: /***/ (
+ module,
+ __unused_webpack_exports,
+ __webpack_require__
+ ) => {
+ module.exports = __webpack_require__(2397);
+
+ /***/
+ },
+
+ /***/ 4305: /***/ (
+ __unused_webpack_module,
+ __unused_webpack_exports,
+ __webpack_require__
+ ) => {
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/script",
+ function () {
+ return __webpack_require__(8543);
+ },
+ ]);
+ if (false) {
+ }
+
+ /***/
+ },
+
+ /***/ 8543: /***/ (
__unused_webpack_module,
__webpack_exports__,
__webpack_require__
@@ -16,7 +43,7 @@
/* harmony import */ var react_jsx_runtime__WEBPACK_IMPORTED_MODULE_0__ =
__webpack_require__(1503);
/* harmony import */ var next_script__WEBPACK_IMPORTED_MODULE_1__ =
- __webpack_require__(5964);
+ __webpack_require__(2398);
/* harmony import */ var next_script__WEBPACK_IMPORTED_MODULE_1___default =
/*#__PURE__*/ __webpack_require__.n(
next_script__WEBPACK_IMPORTED_MODULE_1__
@@ -48,40 +75,13 @@
/***/
},
-
- /***/ 5964: /***/ (
- module,
- __unused_webpack_exports,
- __webpack_require__
- ) => {
- module.exports = __webpack_require__(297);
-
- /***/
- },
-
- /***/ 8803: /***/ (
- __unused_webpack_module,
- __unused_webpack_exports,
- __webpack_require__
- ) => {
- (window.__NEXT_P = window.__NEXT_P || []).push([
- "/script",
- function () {
- return __webpack_require__(661);
- },
- ]);
- if (false) {
- }
-
- /***/
- },
},
/******/ (__webpack_require__) => {
// webpackRuntimeModules
/******/ var __webpack_exec__ = (moduleId) =>
__webpack_require__((__webpack_require__.s = moduleId));
/******/ __webpack_require__.O(0, [636, 6593, 8792], () =>
- __webpack_exec__(8803)
+ __webpack_exec__(4305)
);
/******/ var __webpack_exports__ = __webpack_require__.O();
/******/ _N_E = __webpack_exports__;Diff for withRouter-HASH.js
@@ -1,24 +1,17 @@
(self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
[3263],
{
- /***/ 3163: /***/ (
- __unused_webpack_module,
+ /***/ 1840: /***/ (
+ module,
__unused_webpack_exports,
__webpack_require__
) => {
- (window.__NEXT_P = window.__NEXT_P || []).push([
- "/withRouter",
- function () {
- return __webpack_require__(3295);
- },
- ]);
- if (false) {
- }
+ module.exports = __webpack_require__(1903);
/***/
},
- /***/ 3295: /***/ (
+ /***/ 2037: /***/ (
__unused_webpack_module,
__webpack_exports__,
__webpack_require__
@@ -33,7 +26,7 @@
/* harmony import */ var react_jsx_runtime__WEBPACK_IMPORTED_MODULE_0__ =
__webpack_require__(1503);
/* harmony import */ var next_router__WEBPACK_IMPORTED_MODULE_1__ =
- __webpack_require__(7798);
+ __webpack_require__(1840);
/* harmony import */ var next_router__WEBPACK_IMPORTED_MODULE_1___default =
/*#__PURE__*/ __webpack_require__.n(
next_router__WEBPACK_IMPORTED_MODULE_1__
@@ -52,12 +45,19 @@
/***/
},
- /***/ 7798: /***/ (
- module,
+ /***/ 4041: /***/ (
+ __unused_webpack_module,
__unused_webpack_exports,
__webpack_require__
) => {
- module.exports = __webpack_require__(9587);
+ (window.__NEXT_P = window.__NEXT_P || []).push([
+ "/withRouter",
+ function () {
+ return __webpack_require__(2037);
+ },
+ ]);
+ if (false) {
+ }
/***/
},
@@ -67,7 +67,7 @@
/******/ var __webpack_exec__ = (moduleId) =>
__webpack_require__((__webpack_require__.s = moduleId));
/******/ __webpack_require__.O(0, [636, 6593, 8792], () =>
- __webpack_exec__(3163)
+ __webpack_exec__(4041)
);
/******/ var __webpack_exports__ = __webpack_require__.O();
/******/ _N_E = __webpack_exports__;Diff for 4498-HASH.js
failed to diffDiff for 9225-HASH.js
@@ -1,32 +1,81 @@
"use strict";
(self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
- [9225],
+ [8439],
{
- /***/ 2: /***/ (__unused_webpack_module, exports, __webpack_require__) => {
+ /***/ 405: /***/ (
+ __unused_webpack_module,
+ exports,
+ __webpack_require__
+ ) => {
Object.defineProperty(exports, "__esModule", {
value: true,
});
- Object.defineProperty(exports, "ImageConfigContext", {
+ Object.defineProperty(exports, "default", {
enumerable: true,
get: function () {
- return ImageConfigContext;
+ return SideEffect;
},
});
- const _interop_require_default = __webpack_require__(9010);
- const _react = /*#__PURE__*/ _interop_require_default._(
- __webpack_require__(8879)
- );
- const _imageconfig = __webpack_require__(1686);
- const ImageConfigContext = _react.default.createContext(
- _imageconfig.imageConfigDefault
- );
- if (false) {
- } //# sourceMappingURL=image-config-context.shared-runtime.js.map
+ const _react = __webpack_require__(1774);
+ const isServer = "object" === "undefined";
+ const useClientOnlyLayoutEffect = isServer
+ ? () => {}
+ : _react.useLayoutEffect;
+ const useClientOnlyEffect = isServer ? () => {} : _react.useEffect;
+ function SideEffect(props) {
+ const { headManager, reduceComponentsToState } = props;
+ function emitChange() {
+ if (headManager && headManager.mountedInstances) {
+ const headElements = _react.Children.toArray(
+ Array.from(headManager.mountedInstances).filter(Boolean)
+ );
+ headManager.updateHead(reduceComponentsToState(headElements));
+ }
+ }
+ if (isServer) {
+ headManager?.mountedInstances?.add(props.children);
+ emitChange();
+ }
+ useClientOnlyLayoutEffect(() => {
+ headManager?.mountedInstances?.add(props.children);
+ return () => {
+ headManager?.mountedInstances?.delete(props.children);
+ };
+ });
+ // We need to call `updateHead` method whenever the `SideEffect` is trigger in all
+ // life-cycles: mount, update, unmount. However, if there are multiple `SideEffect`s
+ // being rendered, we only trigger the method from the last one.
+ // This is ensured by keeping the last unflushed `updateHead` in the `_pendingUpdate`
+ // singleton in the layout effect pass, and actually trigger it in the effect pass.
+ useClientOnlyLayoutEffect(() => {
+ if (headManager) {
+ headManager._pendingUpdate = emitChange;
+ }
+ return () => {
+ if (headManager) {
+ headManager._pendingUpdate = emitChange;
+ }
+ };
+ });
+ useClientOnlyEffect(() => {
+ if (headManager && headManager._pendingUpdate) {
+ headManager._pendingUpdate();
+ headManager._pendingUpdate = null;
+ }
+ return () => {
+ if (headManager && headManager._pendingUpdate) {
+ headManager._pendingUpdate();
+ headManager._pendingUpdate = null;
+ }
+ };
+ });
+ return null;
+ } //# sourceMappingURL=side-effect.js.map
/***/
},
- /***/ 1169: /***/ (
+ /***/ 1155: /***/ (
__unused_webpack_module,
exports,
__webpack_require__
@@ -40,9 +89,9 @@
return getImgProps;
},
});
- const _warnonce = __webpack_require__(4352);
- const _imageblursvg = __webpack_require__(2314);
- const _imageconfig = __webpack_require__(1686);
+ const _warnonce = __webpack_require__(5358);
+ const _imageblursvg = __webpack_require__(6924);
+ const _imageconfig = __webpack_require__(9712);
const VALID_LOADING_VALUES =
/* unused pure expression or super */ null && [
"lazy",
@@ -473,243 +522,40 @@
/***/
},
- /***/ 1666: /***/ (module, exports, __webpack_require__) => {
- /* __next_internal_client_entry_do_not_use__ cjs */
+ /***/ 1417: /***/ (
+ __unused_webpack_module,
+ exports,
+ __webpack_require__
+ ) => {
Object.defineProperty(exports, "__esModule", {
value: true,
});
- 0 && 0;
- function _export(target, all) {
- for (var name in all)
- Object.defineProperty(target, name, {
- enumerable: true,
- get: all[name],
- });
- }
- _export(exports, {
- default: function () {
+ Object.defineProperty(exports, "default", {
+ enumerable: true,
+ get: function () {
return _default;
},
- defaultHead: function () {
- return defaultHead;
- },
});
- const _interop_require_default = __webpack_require__(9010);
- const _interop_require_wildcard = __webpack_require__(2275);
- const _jsxruntime = __webpack_require__(1024);
- const _react = /*#__PURE__*/ _interop_require_wildcard._(
- __webpack_require__(8879)
- );
- const _sideeffect = /*#__PURE__*/ _interop_require_default._(
- __webpack_require__(2543)
- );
- const _headmanagercontextsharedruntime = __webpack_require__(5428);
- const _warnonce = __webpack_require__(4352);
- function defaultHead() {
- const head = [
- /*#__PURE__*/ (0, _jsxruntime.jsx)(
- "meta",
- {
- charSet: "utf-8",
- },
- "charset"
- ),
- /*#__PURE__*/ (0, _jsxruntime.jsx)(
- "meta",
- {
- name: "viewport",
- content: "width=device-width",
- },
- "viewport"
- ),
- ];
- return head;
- }
- function onlyReactElement(list, child) {
- // React children can be "string" or "number" in this case we ignore them for backwards compat
- if (typeof child === "string" || typeof child === "number") {
- return list;
- }
- // Adds support for React.Fragment
- if (child.type === _react.default.Fragment) {
- return list.concat(
- _react.default.Children.toArray(child.props.children).reduce(
- (fragmentList, fragmentChild) => {
- if (
- typeof fragmentChild === "string" ||
- typeof fragmentChild === "number"
- ) {
- return fragmentList;
- }
- return fragmentList.concat(fragmentChild);
- },
- []
- )
- );
+ const _findclosestquality = __webpack_require__(1639);
+ function defaultLoader({ config, src, width, quality }) {
+ if (false) {
}
- return list.concat(child);
- }
- const METATYPES = ["name", "httpEquiv", "charSet", "itemProp"];
- /*
- returns a function for filtering head child elements
- which shouldn't be duplicated, like <title/>
- Also adds support for deduplicated `key` properties
-*/ function unique() {
- const keys = new Set();
- const tags = new Set();
- const metaTypes = new Set();
- const metaCategories = {};
- return (h) => {
- let isUnique = true;
- let hasKey = false;
- if (h.key && typeof h.key !== "number" && h.key.indexOf("$") > 0) {
- hasKey = true;
- const key = h.key.slice(h.key.indexOf("$") + 1);
- if (keys.has(key)) {
- isUnique = false;
- } else {
- keys.add(key);
- }
- }
- // eslint-disable-next-line default-case
- switch (h.type) {
- case "title":
- case "base":
- if (tags.has(h.type)) {
- isUnique = false;
- } else {
- tags.add(h.type);
- }
- break;
- case "meta":
- for (let i = 0, len = METATYPES.length; i < len; i++) {
- const metatype = METATYPES[i];
- if (!h.props.hasOwnProperty(metatype)) continue;
- if (metatype === "charSet") {
- if (metaTypes.has(metatype)) {
- isUnique = false;
- } else {
- metaTypes.add(metatype);
- }
- } else {
- const category = h.props[metatype];
- const categories = metaCategories[metatype] || new Set();
- if (
- (metatype !== "name" || !hasKey) &&
- categories.has(category)
- ) {
- isUnique = false;
- } else {
- categories.add(category);
- metaCategories[metatype] = categories;
- }
- }
- }
- break;
- }
- return isUnique;
- };
- }
- /**
- *
- * @param headChildrenElements List of children of <Head>
- */ function reduceComponents(headChildrenElements) {
- return headChildrenElements
- .reduce(onlyReactElement, [])
- .reverse()
- .concat(defaultHead().reverse())
- .filter(unique())
- .reverse()
- .map((c, i) => {
- const key = c.key || i;
- if (false) {
- }
- return /*#__PURE__*/ _react.default.cloneElement(c, {
- key,
- });
- });
- }
- /**
- * This component injects elements to `<head>` of your page.
- * To avoid duplicated `tags` in `<head>` you can use the `key` property, which will make sure every tag is only rendered once.
- */ function Head({ children }) {
- const headManager = (0, _react.useContext)(
- _headmanagercontextsharedruntime.HeadManagerContext
- );
- return /*#__PURE__*/ (0, _jsxruntime.jsx)(_sideeffect.default, {
- reduceComponentsToState: reduceComponents,
- headManager: headManager,
- children: children,
- });
- }
- const _default = Head;
- if (
- (typeof exports.default === "function" ||
- (typeof exports.default === "object" && exports.default !== null)) &&
- typeof exports.default.__esModule === "undefined"
- ) {
- Object.defineProperty(exports.default, "__esModule", {
- value: true,
- });
- Object.assign(exports.default, exports);
- module.exports = exports.default;
- } //# sourceMappingURL=head.js.map
-
- /***/
- },
-
- /***/ 1686: /***/ (__unused_webpack_module, exports) => {
- Object.defineProperty(exports, "__esModule", {
- value: true,
- });
- 0 && 0;
- function _export(target, all) {
- for (var name in all)
- Object.defineProperty(target, name, {
- enumerable: true,
- get: all[name],
- });
+ const q = (0, _findclosestquality.findClosestQuality)(quality, config);
+ return `${config.path}?url=${encodeURIComponent(
+ src
+ )}&w=${width}&q=${q}${
+ src.startsWith("/_next/static/media/") && false ? 0 : ""
+ }`;
}
- _export(exports, {
- VALID_LOADERS: function () {
- return VALID_LOADERS;
- },
- imageConfigDefault: function () {
- return imageConfigDefault;
- },
- });
- const VALID_LOADERS = [
- "default",
- "imgix",
- "cloudinary",
- "akamai",
- "custom",
- ];
- const imageConfigDefault = {
- deviceSizes: [640, 750, 828, 1080, 1200, 1920, 2048, 3840],
- imageSizes: [16, 32, 48, 64, 96, 128, 256, 384],
- path: "/_next/image",
- loader: "default",
- loaderFile: "",
- /**
- * @deprecated Use `remotePatterns` instead to protect your application from malicious users.
- */ domains: [],
- disableStaticImages: false,
- minimumCacheTTL: 14400,
- formats: ["image/webp"],
- dangerouslyAllowSVG: false,
- contentSecurityPolicy: `script-src 'none'; frame-src 'none'; sandbox;`,
- contentDispositionType: "attachment",
- localPatterns: undefined,
- remotePatterns: [],
- qualities: [75],
- unoptimized: false,
- }; //# sourceMappingURL=image-config.js.map
+ // We use this to determine if the import is the default loader
+ // or a custom loader defined by the user in next.config.js
+ defaultLoader.__next_img_default = true;
+ const _default = defaultLoader; //# sourceMappingURL=image-loader.js.map
/***/
},
- /***/ 2285: /***/ (__unused_webpack_module, exports) => {
+ /***/ 1639: /***/ (__unused_webpack_module, exports) => {
Object.defineProperty(exports, "__esModule", {
value: true,
});
@@ -733,7 +579,35 @@
/***/
},
- /***/ 2314: /***/ (__unused_webpack_module, exports) => {
+ /***/ 2896: /***/ (
+ __unused_webpack_module,
+ exports,
+ __webpack_require__
+ ) => {
+ Object.defineProperty(exports, "__esModule", {
+ value: true,
+ });
+ Object.defineProperty(exports, "ImageConfigContext", {
+ enumerable: true,
+ get: function () {
+ return ImageConfigContext;
+ },
+ });
+ const _interop_require_default = __webpack_require__(2570);
+ const _react = /*#__PURE__*/ _interop_require_default._(
+ __webpack_require__(1774)
+ );
+ const _imageconfig = __webpack_require__(9712);
+ const ImageConfigContext = _react.default.createContext(
+ _imageconfig.imageConfigDefault
+ );
+ if (false) {
+ } //# sourceMappingURL=image-config-context.shared-runtime.js.map
+
+ /***/
+ },
+
+ /***/ 6924: /***/ (__unused_webpack_module, exports) => {
/**
* A shared function, used on both client and server, to generate a SVG blur placeholder.
*/
@@ -772,113 +646,7 @@
/***/
},
- /***/ 2543: /***/ (
- __unused_webpack_module,
- exports,
- __webpack_require__
- ) => {
- Object.defineProperty(exports, "__esModule", {
- value: true,
- });
- Object.defineProperty(exports, "default", {
- enumerable: true,
- get: function () {
- return SideEffect;
- },
- });
- const _react = __webpack_require__(8879);
- const isServer = "object" === "undefined";
- const useClientOnlyLayoutEffect = isServer
- ? () => {}
- : _react.useLayoutEffect;
- const useClientOnlyEffect = isServer ? () => {} : _react.useEffect;
- function SideEffect(props) {
- const { headManager, reduceComponentsToState } = props;
- function emitChange() {
- if (headManager && headManager.mountedInstances) {
- const headElements = _react.Children.toArray(
- Array.from(headManager.mountedInstances).filter(Boolean)
- );
- headManager.updateHead(reduceComponentsToState(headElements));
- }
- }
- if (isServer) {
- headManager?.mountedInstances?.add(props.children);
- emitChange();
- }
- useClientOnlyLayoutEffect(() => {
- headManager?.mountedInstances?.add(props.children);
- return () => {
- headManager?.mountedInstances?.delete(props.children);
- };
- });
- // We need to call `updateHead` method whenever the `SideEffect` is trigger in all
- // life-cycles: mount, update, unmount. However, if there are multiple `SideEffect`s
- // being rendered, we only trigger the method from the last one.
- // This is ensured by keeping the last unflushed `updateHead` in the `_pendingUpdate`
- // singleton in the layout effect pass, and actually trigger it in the effect pass.
- useClientOnlyLayoutEffect(() => {
- if (headManager) {
- headManager._pendingUpdate = emitChange;
- }
- return () => {
- if (headManager) {
- headManager._pendingUpdate = emitChange;
- }
- };
- });
- useClientOnlyEffect(() => {
- if (headManager && headManager._pendingUpdate) {
- headManager._pendingUpdate();
- headManager._pendingUpdate = null;
- }
- return () => {
- if (headManager && headManager._pendingUpdate) {
- headManager._pendingUpdate();
- headManager._pendingUpdate = null;
- }
- };
- });
- return null;
- } //# sourceMappingURL=side-effect.js.map
-
- /***/
- },
-
- /***/ 8035: /***/ (
- __unused_webpack_module,
- exports,
- __webpack_require__
- ) => {
- Object.defineProperty(exports, "__esModule", {
- value: true,
- });
- Object.defineProperty(exports, "default", {
- enumerable: true,
- get: function () {
- return _default;
- },
- });
- const _findclosestquality = __webpack_require__(2285);
- function defaultLoader({ config, src, width, quality }) {
- if (false) {
- }
- const q = (0, _findclosestquality.findClosestQuality)(quality, config);
- return `${config.path}?url=${encodeURIComponent(
- src
- )}&w=${width}&q=${q}${
- src.startsWith("/_next/static/media/") && false ? 0 : ""
- }`;
- }
- // We use this to determine if the import is the default loader
- // or a custom loader defined by the user in next.config.js
- defaultLoader.__next_img_default = true;
- const _default = defaultLoader; //# sourceMappingURL=image-loader.js.map
-
- /***/
- },
-
- /***/ 8848: /***/ (module, exports, __webpack_require__) => {
+ /***/ 7614: /***/ (module, exports, __webpack_require__) => {
Object.defineProperty(exports, "__esModule", {
value: true,
});
@@ -888,7 +656,7 @@
return useMergedRef;
},
});
- const _react = __webpack_require__(8879);
+ const _react = __webpack_require__(1774);
function useMergedRef(refA, refB) {
const cleanupA = (0, _react.useRef)(null);
const cleanupB = (0, _react.useRef)(null);
@@ -954,32 +722,7 @@
/***/
},
- /***/ 9059: /***/ (
- __unused_webpack_module,
- exports,
- __webpack_require__
- ) => {
- Object.defineProperty(exports, "__esModule", {
- value: true,
- });
- Object.defineProperty(exports, "RouterContext", {
- enumerable: true,
- get: function () {
- return RouterContext;
- },
- });
- const _interop_require_default = __webpack_require__(9010);
- const _react = /*#__PURE__*/ _interop_require_default._(
- __webpack_require__(8879)
- );
- const RouterContext = _react.default.createContext(null);
- if (false) {
- } //# sourceMappingURL=router-context.shared-runtime.js.map
-
- /***/
- },
-
- /***/ 9225: /***/ (module, exports, __webpack_require__) => {
+ /***/ 8439: /***/ (module, exports, __webpack_require__) => {
/* __next_internal_client_entry_do_not_use__ cjs */
Object.defineProperty(exports, "__esModule", {
value: true,
@@ -990,27 +733,27 @@
return Image;
},
});
- const _interop_require_default = __webpack_require__(9010);
- const _interop_require_wildcard = __webpack_require__(2275);
- const _jsxruntime = __webpack_require__(1024);
+ const _interop_require_default = __webpack_require__(2570);
+ const _interop_require_wildcard = __webpack_require__(5643);
+ const _jsxruntime = __webpack_require__(2014);
const _react = /*#__PURE__*/ _interop_require_wildcard._(
- __webpack_require__(8879)
+ __webpack_require__(1774)
);
const _reactdom = /*#__PURE__*/ _interop_require_default._(
- __webpack_require__(3869)
+ __webpack_require__(7499)
);
const _head = /*#__PURE__*/ _interop_require_default._(
- __webpack_require__(1666)
+ __webpack_require__(9452)
);
- const _getimgprops = __webpack_require__(1169);
- const _imageconfig = __webpack_require__(1686);
- const _imageconfigcontextsharedruntime = __webpack_require__(2);
- const _warnonce = __webpack_require__(4352);
- const _routercontextsharedruntime = __webpack_require__(9059);
+ const _getimgprops = __webpack_require__(1155);
+ const _imageconfig = __webpack_require__(9712);
+ const _imageconfigcontextsharedruntime = __webpack_require__(2896);
+ const _warnonce = __webpack_require__(5358);
+ const _routercontextsharedruntime = __webpack_require__(9813);
const _imageloader = /*#__PURE__*/ _interop_require_default._(
- __webpack_require__(8035)
+ __webpack_require__(1417)
);
- const _usemergedref = __webpack_require__(8848);
+ const _usemergedref = __webpack_require__(7614);
// This is replaced by webpack define plugin
const configEnv = {
deviceSizes: [640, 750, 828, 1080, 1200, 1920, 2048, 3840],
@@ -1331,5 +1074,266 @@
/***/
},
+
+ /***/ 9452: /***/ (module, exports, __webpack_require__) => {
+ /* __next_internal_client_entry_do_not_use__ cjs */
+ Object.defineProperty(exports, "__esModule", {
+ value: true,
+ });
+ 0 && 0;
+ function _export(target, all) {
+ for (var name in all)
+ Object.defineProperty(target, name, {
+ enumerable: true,
+ get: all[name],
+ });
+ }
+ _export(exports, {
+ default: function () {
+ return _default;
+ },
+ defaultHead: function () {
+ return defaultHead;
+ },
+ });
+ const _interop_require_default = __webpack_require__(2570);
+ const _interop_require_wildcard = __webpack_require__(5643);
+ const _jsxruntime = __webpack_require__(2014);
+ const _react = /*#__PURE__*/ _interop_require_wildcard._(
+ __webpack_require__(1774)
+ );
+ const _sideeffect = /*#__PURE__*/ _interop_require_default._(
+ __webpack_require__(405)
+ );
+ const _headmanagercontextsharedruntime = __webpack_require__(5326);
+ const _warnonce = __webpack_require__(5358);
+ function defaultHead() {
+ const head = [
+ /*#__PURE__*/ (0, _jsxruntime.jsx)(
+ "meta",
+ {
+ charSet: "utf-8",
+ },
+ "charset"
+ ),
+ /*#__PURE__*/ (0, _jsxruntime.jsx)(
+ "meta",
+ {
+ name: "viewport",
+ content: "width=device-width",
+ },
+ "viewport"
+ ),
+ ];
+ return head;
+ }
+ function onlyReactElement(list, child) {
+ // React children can be "string" or "number" in this case we ignore them for backwards compat
+ if (typeof child === "string" || typeof child === "number") {
+ return list;
+ }
+ // Adds support for React.Fragment
+ if (child.type === _react.default.Fragment) {
+ return list.concat(
+ _react.default.Children.toArray(child.props.children).reduce(
+ (fragmentList, fragmentChild) => {
+ if (
+ typeof fragmentChild === "string" ||
+ typeof fragmentChild === "number"
+ ) {
+ return fragmentList;
+ }
+ return fragmentList.concat(fragmentChild);
+ },
+ []
+ )
+ );
+ }
+ return list.concat(child);
+ }
+ const METATYPES = ["name", "httpEquiv", "charSet", "itemProp"];
+ /*
+ returns a function for filtering head child elements
+ which shouldn't be duplicated, like <title/>
+ Also adds support for deduplicated `key` properties
+*/ function unique() {
+ const keys = new Set();
+ const tags = new Set();
+ const metaTypes = new Set();
+ const metaCategories = {};
+ return (h) => {
+ let isUnique = true;
+ let hasKey = false;
+ if (h.key && typeof h.key !== "number" && h.key.indexOf("$") > 0) {
+ hasKey = true;
+ const key = h.key.slice(h.key.indexOf("$") + 1);
+ if (keys.has(key)) {
+ isUnique = false;
+ } else {
+ keys.add(key);
+ }
+ }
+ // eslint-disable-next-line default-case
+ switch (h.type) {
+ case "title":
+ case "base":
+ if (tags.has(h.type)) {
+ isUnique = false;
+ } else {
+ tags.add(h.type);
+ }
+ break;
+ case "meta":
+ for (let i = 0, len = METATYPES.length; i < len; i++) {
+ const metatype = METATYPES[i];
+ if (!h.props.hasOwnProperty(metatype)) continue;
+ if (metatype === "charSet") {
+ if (metaTypes.has(metatype)) {
+ isUnique = false;
+ } else {
+ metaTypes.add(metatype);
+ }
+ } else {
+ const category = h.props[metatype];
+ const categories = metaCategories[metatype] || new Set();
+ if (
+ (metatype !== "name" || !hasKey) &&
+ categories.has(category)
+ ) {
+ isUnique = false;
+ } else {
+ categories.add(category);
+ metaCategories[metatype] = categories;
+ }
+ }
+ }
+ break;
+ }
+ return isUnique;
+ };
+ }
+ /**
+ *
+ * @param headChildrenElements List of children of <Head>
+ */ function reduceComponents(headChildrenElements) {
+ return headChildrenElements
+ .reduce(onlyReactElement, [])
+ .reverse()
+ .concat(defaultHead().reverse())
+ .filter(unique())
+ .reverse()
+ .map((c, i) => {
+ const key = c.key || i;
+ if (false) {
+ }
+ return /*#__PURE__*/ _react.default.cloneElement(c, {
+ key,
+ });
+ });
+ }
+ /**
+ * This component injects elements to `<head>` of your page.
+ * To avoid duplicated `tags` in `<head>` you can use the `key` property, which will make sure every tag is only rendered once.
+ */ function Head({ children }) {
+ const headManager = (0, _react.useContext)(
+ _headmanagercontextsharedruntime.HeadManagerContext
+ );
+ return /*#__PURE__*/ (0, _jsxruntime.jsx)(_sideeffect.default, {
+ reduceComponentsToState: reduceComponents,
+ headManager: headManager,
+ children: children,
+ });
+ }
+ const _default = Head;
+ if (
+ (typeof exports.default === "function" ||
+ (typeof exports.default === "object" && exports.default !== null)) &&
+ typeof exports.default.__esModule === "undefined"
+ ) {
+ Object.defineProperty(exports.default, "__esModule", {
+ value: true,
+ });
+ Object.assign(exports.default, exports);
+ module.exports = exports.default;
+ } //# sourceMappingURL=head.js.map
+
+ /***/
+ },
+
+ /***/ 9712: /***/ (__unused_webpack_module, exports) => {
+ Object.defineProperty(exports, "__esModule", {
+ value: true,
+ });
+ 0 && 0;
+ function _export(target, all) {
+ for (var name in all)
+ Object.defineProperty(target, name, {
+ enumerable: true,
+ get: all[name],
+ });
+ }
+ _export(exports, {
+ VALID_LOADERS: function () {
+ return VALID_LOADERS;
+ },
+ imageConfigDefault: function () {
+ return imageConfigDefault;
+ },
+ });
+ const VALID_LOADERS = [
+ "default",
+ "imgix",
+ "cloudinary",
+ "akamai",
+ "custom",
+ ];
+ const imageConfigDefault = {
+ deviceSizes: [640, 750, 828, 1080, 1200, 1920, 2048, 3840],
+ imageSizes: [16, 32, 48, 64, 96, 128, 256, 384],
+ path: "/_next/image",
+ loader: "default",
+ loaderFile: "",
+ /**
+ * @deprecated Use `remotePatterns` instead to protect your application from malicious users.
+ */ domains: [],
+ disableStaticImages: false,
+ minimumCacheTTL: 14400,
+ formats: ["image/webp"],
+ dangerouslyAllowSVG: false,
+ contentSecurityPolicy: `script-src 'none'; frame-src 'none'; sandbox;`,
+ contentDispositionType: "attachment",
+ localPatterns: undefined,
+ remotePatterns: [],
+ qualities: [75],
+ unoptimized: false,
+ }; //# sourceMappingURL=image-config.js.map
+
+ /***/
+ },
+
+ /***/ 9813: /***/ (
+ __unused_webpack_module,
+ exports,
+ __webpack_require__
+ ) => {
+ Object.defineProperty(exports, "__esModule", {
+ value: true,
+ });
+ Object.defineProperty(exports, "RouterContext", {
+ enumerable: true,
+ get: function () {
+ return RouterContext;
+ },
+ });
+ const _interop_require_default = __webpack_require__(2570);
+ const _react = /*#__PURE__*/ _interop_require_default._(
+ __webpack_require__(1774)
+ );
+ const RouterContext = _react.default.createContext(null);
+ if (false) {
+ } //# sourceMappingURL=router-context.shared-runtime.js.map
+
+ /***/
+ },
},
]);Diff for main-HASH.js
Diff too large to display
samselikoff
force-pushed
the
reenable-legacy-behavior-link
branch
from
3ce9a06 to
f6877c8
Compare
samselikoff
force-pushed
the
reenable-legacy-behavior-link
branch
from
f8a50f3 to
0e9d043
Compare
samselikoff
force-pushed
the
reenable-legacy-behavior-link
branch
from
68b6457 to
d00436f
Compare
samselikoff
force-pushed
the
reenable-legacy-behavior-link
branch
from
d00436f to
c9ba18e
Compare
| // This will return the first child, if multiple are provided it will throw an error | ||
| let child: any | ||
| if (legacyBehavior) { | ||
| if ((children as any)?.$$typeof === Symbol.for('react.lazy')) { |
There was a problem hiding this comment.
Suggested change
| if ((children as any)?.$$typeof === Symbol.for('react.lazy')) { | |
| if ((children as any)?.type?.$$typeof === Symbol.for('react.lazy')) { |
The check for detecting React.lazy components is incorrect - it checks children.$$typeof instead of children.type.$$typeof, which means lazy components won't be properly detected and will fail with a less helpful error message later.
View Details
Analysis
React.lazy component detection fails in Link legacyBehavior mode
What fails: Link component's lazy component check at packages/next/src/client/app-dir/link.tsx:531 fails to detect React.lazy components, checking children.$$typeof instead of children.type.$$typeof
How to reproduce:
import { lazy } from 'react';
import Link from 'next/link';
const LazyComponent = lazy(() => import('./MyComponent'));
// This should throw a helpful error but doesn't detect the lazy component
<Link href="/test" legacyBehavior>
<LazyComponent />
</Link>Result: The lazy component check fails because when JSX like <LazyComponent /> is created, it produces a React element where:
element.$$typeof === Symbol.for('react.element')(or'react.transitional.element'in React 19)element.type.$$typeof === Symbol.for('react.lazy')✓
The current check (children as any)?.$$typeof === Symbol.for('react.lazy') returns false, so the lazy component passes through undetected and users encounter generic React errors from React.Children.only() or React.cloneElement() instead of the intended helpful error message.
Expected: Should detect lazy components correctly and throw the helpful error: "<Link legacyBehavior> received a direct child that is either a Server Component, or JSX that was loaded with React.lazy()..."
Verification: React lazy component structure and testing confirms that lazy components in JSX have the react.lazy symbol at element.type.$$typeof, not element.$$typeof.
Inconsistency: The check in link.react-server.tsx:17 correctly uses (props.children as any)?.type?.$$typeof === Symbol.for('react.lazy'), but link.tsx:531 incorrectly uses (children as any)?.$$typeof === Symbol.for('react.lazy').
samselikoff
force-pushed
the
reenable-legacy-behavior-link
branch
from
c9ba18e to
d5ae88f
Compare
eps1lon
approved these changes
Oct 8, 2025
ijjk
approved these changes
Oct 8, 2025
…t.js into reenable-legacy-behavior-link # Conflicts: # test/e2e/legacy-link-behavior/index.test.ts # test/e2e/legacy-link-behavior/validations.console.test.ts
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #83003,
legacyBehaviorandpassHrefwere removed from<Link>. However, this turned out to be a bit premature—despite most usage being covered by the newer<Link>APIs, there's some use cases we don't yet have good alternatives for.We expect to solve this with an API that uses Fragment Refs once they're available in React. For now, we're re-enabling these flags.