Skip to content

RSDK-11731 — Remove GetImage, Format, and RenderFrame from camera.proto #758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

RSDK-11731 — Remove GetImage, Format, and RenderFrame from camera.proto #758

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
05aeec5
Remove GetImage, Format, and RenderFrame from camera.proto
hexbabe Oct 1, 2025
8eb0a10
Remove unused import
hexbabe Oct 1, 2025
2804cb6
Delete renderframe request
hexbabe Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 1 addition & 48 deletions proto/viam/component/camera/v1/camera.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,30 +4,17 @@ package viam.component.camera.v1;

import "common/v1/common.proto";
import "google/api/annotations.proto";
import "google/api/httpbody.proto";
import "google/protobuf/struct.proto";

option go_package = "go.viam.com/api/component/camera/v1";
option java_package = "com.viam.component.camera.v1";

// A CameraService services all cameras associated with a robot
service CameraService {
// GetImage returns a frame from a camera of the underlying robot. A specific MIME type
// can be requested but may not necessarily be the same one returned.
rpc GetImage(GetImageRequest) returns (GetImageResponse) {
option (google.api.http) = {get: "/viam/api/v1/component/camera/{name}/image"};
}

rpc GetImages(GetImagesRequest) returns (GetImagesResponse) {
option (google.api.http) = {get: "/viam/api/v1/component/camera/{name}/images"};
}

// RenderFrame renders a frame from a camera of the underlying robot to an HTTP response. A specific MIME type
// can be requested but may not necessarily be the same one returned.
rpc RenderFrame(RenderFrameRequest) returns (google.api.HttpBody) {
option (google.api.http) = {get: "/viam/api/v1/component/camera/{name}/render_frame"};
}

// GetPointCloud returns a point cloud from a camera of the underlying robot. A specific MIME type
// can be requested but may not necessarily be the same one returned.
rpc GetPointCloud(GetPointCloudRequest) returns (GetPointCloudResponse) {
Expand All @@ -50,22 +37,6 @@ service CameraService {
}
}

message GetImageRequest {
// Name of a camera
string name = 1;
// Requested MIME type of response
string mime_type = 2;
// Additional arguments to the method
google.protobuf.Struct extra = 99;
}

message GetImageResponse {
// Actual MIME type of response
string mime_type = 1;
// Frame in bytes
bytes image = 2;
}

message GetImagesRequest {
// Name of a camera
string name = 1;
Expand All @@ -86,31 +57,13 @@ message GetImagesResponse {
message Image {
// the name of the sensor where the image came from
string source_name = 1;
// format of the response image bytes
Format format = 2;
reserved 2; // previously use for Format, reserving as per https://protobuf.dev/programming-guides/proto3/#deleting
// image in bytes
bytes image = 3;
// The mime type of the image
string mime_type = 4;
}

enum Format {
FORMAT_UNSPECIFIED = 0;
FORMAT_RAW_RGBA = 1;
FORMAT_RAW_DEPTH = 2;
FORMAT_JPEG = 3;
FORMAT_PNG = 4;
}

message RenderFrameRequest {
// Name of a camera
string name = 1;
// Requested MIME type of response
string mime_type = 2;
// Additional arguments to the method
google.protobuf.Struct extra = 99;
}

message GetPointCloudRequest {
// Name of a camera
string name = 1;
Expand Down
Loading