RSDK-11248 Disable restart checking logic with new agents and update restart_status endpoint #5324
Conversation
viambot
added
the
safe to test
web/cmd/droid/droid.go
Outdated
| // NOTE(benjirewis): In RSDK-11248, we removed the restart checking logic from | ||
| // viam-server and put it in viam-agent. This method used to set a flag used by restart | ||
| // checking logic, but since that no longer exists and we have no users of this droid | ||
| // code, we no longer support this method. |
There was a problem hiding this comment.
cc @abe-winter since we discussed this offline.
Correct; see this comment on the agent PR. |
viambot
added
safe to test
viambot
added
safe to test
| // | ||
| // TODO(RSDK-12057): Remove sensitivity to this environment variable once we fully | ||
| // remove all NeedsRestart checking logic from viam-server. | ||
| ViamAgentHandlesNeedsRestartChecking = "VIAM_AGENT_HANDLES_NEEDS_RESTART_CHECKING" |
There was a problem hiding this comment.
We now continue to handle checking NeedsRestart in a background goroutine in the server if VIAM_AGENT_HANDLES_NEEDS_RESTART_CHECKING is unset (newer versions of agent will set it unconditionally when launching viam-server). It was determined offline that we do want to support old-agent/new-server setups for a while, and eventually completely remove needs restart checking functionality from the rdk with RSDK-12057.
Thanks to @jmatth for the env var idea 🎉 .
| func DroidStopHook() { //nolint:revive | ||
| server.ForceRestart = true | ||
| // We have no users of this droid code, so we no longer support this method. | ||
| logger.Error("DroidStopHook is no longer supported") |
There was a problem hiding this comment.
@abe-winter we're not actually removing needs restart checking functionality from viam-server yet, but we will in RSDK-12057. So I don't get confused later, I'm still going to remove the ForceRestart flag and its setting above now if that SGTY.
benjirewis
changed the title
RSDK-11248
Disables restart checking logic (to be added to agent with viamrobotics/agent#153) when
viam-agentis runningviam-serverand sets a particular environment variable. Updates therestart_statusendpoint to consistently reportdoes_not_handle_needs_restart: truein the served JSON (to be used by agent to determine whether the runningviam-serveris new enough to not handle restart checking logic).