Skip to content

RSDK-12072 Hardcode GOARCH=amd64 in make windows target #5340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2025
Merged

RSDK-12072 Hardcode GOARCH=amd64 in make windows target #5340

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,8 @@ full-static:
# should be kept in sync with the windows build in the BuildViamServer helper in testutils/file_utils.go
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The referenced method seems not relevant for this change.

windows:
mkdir -p bin/windows
GOOS=windows go build -tags no_cgo $(GCFLAGS) -ldflags="-extldflags=-static $(COMMON_LDFLAGS)" -o bin/windows/viam-server-$(shell go env GOARCH).exe ./web/cmd/server
cd bin/windows && zip viam.zip viam-server-$(shell go env GOARCH).exe
GOOS=windows GOARCH=amd64 go build -tags no_cgo $(GCFLAGS) -ldflags="-extldflags=-static $(COMMON_LDFLAGS)" -o bin/windows/viam-server-amd64.exe ./web/cmd/server
cd bin/windows && zip viam.zip viam-server-amd64.exe

server-static-compressed: server-static
upx --best --lzma $(BIN_OUTPUT_PATH)/viam-server
Expand Down
Loading