DATA 4228: Update SDKs and CLI #571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/app/data-client.ts
Outdated
| query: Uint8Array[] | Record<string, Date | JsonValue>[], | ||
| schedule: string | ||
| schedule: string, | ||
| dataSourceType?: string |
There was a problem hiding this comment.
The type of dataSourceType should match this: https://github.com/viamrobotics/viam-typescript-sdk/blob/867c57aa402adf1f63bb94a23dd1a71112d5b71c/src/app/data-client.ts#L17C3-L17C24.
Here is how we use it for reference:
viam-typescript-sdk/src/app/data-client.ts
Line 237 in 867c57a
gloriacai01
reviewed
Jun 13, 2025
src/app/data-client.ts
Outdated
| inputDataSourceType !== TabularDataSourceType.STANDARD && | ||
| inputDataSourceType !== TabularDataSourceType.HOT_STORAGE | ||
| ) { | ||
| throw new Error('Invalid data source type'); |
There was a problem hiding this comment.
can remove this check since we have this logic on the app side already!
stuqdog
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating TS sdk to include dataSourceType in CREATE functionality.
Updated tests to match this change and all tests are passing.