CONSULT-1797-implement-FileUpload-on-the-typescript-SDK #642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuqdog
approved these changes
Sep 30, 2025
src/app/data-client.ts
Outdated
| * @param componentName The name of the component used to capture the data | ||
| * @param methodName The name of the method used to capture the data. | ||
| * @param fileExtension The file extension of binary data including the | ||
| * @param filename The file extension of binary data including the |
There was a problem hiding this comment.
This is kind of confusing to me, since we're still in the comment saying we expect a file extension.
src/app/data-client.ts
Outdated
| tags?: string[], | ||
| datasetIds?: string[] | ||
| ) { | ||
| const fileExtension = fileName.includes('.') ? fileName.split('.')[1] : ''; |
There was a problem hiding this comment.
I don't think anything in principle would prevent someone from having a file named, e.g., my-image_v0.2.jpg, might be better to always grab the last entry from fileName.split rather than the second one?
nicksanford
commented
Sep 30, 2025
Comment on lines
+73
to
+79
| componentType?: string; | ||
|
|
||
| /** Optional name of the component associated with the file. */ | ||
| componentName?: string; | ||
|
|
||
| /** Optional name of the method associated with the file. */ | ||
| methodName?: string; |
There was a problem hiding this comment.
remove, these are invalid on arbitrary data uploads
nicksanford
commented
Sep 30, 2025
stuqdog
approved these changes
Oct 1, 2025
src/app/data-client.ts
Outdated
| * '123abc45-1234-5678-90ab-cdef12345678', | ||
| * '.jpg', | ||
| * [new Date('2025-03-19'), new Date('2025-03-19')] | ||
| * 'INSERT YOUR PART ID' |
There was a problem hiding this comment.
(minor) This is unclear to me. Is this supposed to be an arg? If so we need a comma and the partID goes after the binary data, not before.
nicksanford
commented
Oct 1, 2025
nicksanford
commented
Oct 1, 2025
nicksanford
commented
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.