Skip to content

Conversation

@jrohland
Copy link

Vue 2.7 introduced the composition API as part of the base framework so that the @vue/composition-api dependency is no longer required. PR #1077 removed the dependency but didn't update the code to fix the references to the old dependency. This PR should complete the work in updating Vue as well as removing @vue/composition-api.

@adrienWeiss
Copy link

@jrohland thank you for this PR, I just tested it on my project and it appears to be working fine 👍
@vinayakkulkarni do you think you can do a legacy version release so that those of us trying to update to Vue 2.7 are able to remove @vue/composition-api without having to downgrade v-mapbox to 1.7.3 ? That would be really appreciated.
Thank you for your work & please let us know if more help or tests are needed 🙏

@vinayakkulkarni vinayakkulkarni self-requested a review March 9, 2023 19:52
@vinayakkulkarni
Copy link
Owner

I'll test this over the weekend. Thanks.

@vinayakkulkarni vinayakkulkarni self-assigned this Mar 9, 2023
@vinayakkulkarni vinayakkulkarni added enhancement New feature or request dependencies Pull requests that update a dependency file labels Mar 9, 2023
@davidsandoz
Copy link

Hi @vinayakkulkarni, I'd also be quite interested to have this merged. Do you have an idea when you'll have time for this? Thanks!

@julianstricker
Copy link

Hi @vinayakkulkarni! It would greatly help me if this were merged. When can we expect it?

@BasilaryGroup
Copy link

We really need this PR to be approved. Is there anything we can do to make it happen. Thanks!

@raisiqueira
Copy link

@vinayakkulkarni any status about this merge request? It will be valuable for those that who want to use the v-mapbox with vue 2.7.

@jrohland
Copy link
Author

We've been using our own npm build off of the fork I made to introduce this change until if/when this PR is merged into the original repo. If it helps anyone else out it's available here: https://www.npmjs.com/package/@advisr/v-mapbox

I didn't really want people pointing to our npm build in the case this PR got merged but it's been awhile since I opened this PR and I have a feeling Vue 2.7 support is no longer a priority for them. If you do want to use it you can just point the v-mapbox dependency in your package.json directly to this npm version like this: "v-mapbox": "npm:@advisr/v-mapbox@1.12.0"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants