fix: make pointer events more robust #841
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a few issues with the
AdvancedMarker
when using anchor points. Issues where introduced when Google Maps started to use thegmp-advanced-marker
element by default for the marker.I tried multiple approaches to achieve a "clean" solution, but none of them worked 100%.
Changes:
data-origin="rgm"
attribute to thegmp-advanced-marker
to be able to overwrite the pointer events with a global style tag and to only target the markers originating from this libraryExplanations
Collision detection:
Pointer events:
onClick
event listener for the marker, the marker container gets all pointer events. That means when content is translated by an anchor point, mouse events are also triggered when hovering over the "ghost" element.gmp-advanced-marker
This is what I found to be the least intrusive solution.
fixes #819