Skip to content

Conversation

kylesayrs
Copy link
Collaborator

Purpose

  • Fix faulty test which was using static token quantization
  • Grepped for any other instances of static token quantiztion, none were found

Changes

  • Replace token quant with tensor quant

Testing

  • CI passes

Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Copy link

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed.

Copy link
Contributor

Summary of Changes

Hello @kylesayrs, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a specific issue within the test suite by updating the quantization strategy used in certain test configurations. The change involves switching from 'token' to 'tensor' quantization for input activations, which resolves a faulty test. This ensures the tests accurately reflect the intended behavior and that the 'token' strategy is not inadvertently used elsewhere in the project.

Highlights

  • Test Fix: Corrected a faulty test configuration that was incorrectly using 'static token quantization'.
  • Quantization Strategy Update: Replaced the 'token' quantization strategy with 'tensor' quantization for input activations within the test configuration.
  • Codebase Scan: Verified that no other instances of 'static token quantization' were present in the codebase, ensuring this was an isolated test issue.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes a faulty test by updating the quantization strategy from 'token' to 'tensor'. The change is straightforward and addresses the issue described. I have added one suggestion to refactor the test fixture to improve maintainability by reducing code duplication.

@dsikka dsikka enabled auto-merge (squash) October 10, 2025 19:03
@dsikka dsikka added the ready When a PR is ready for review label Oct 10, 2025
@dsikka dsikka merged commit 4e996f5 into main Oct 10, 2025
10 checks passed
@dsikka dsikka deleted the kylesayrs/fix-static-token branch October 10, 2025 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready When a PR is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants