[Bugfix] fix linkspector ci/cd check #1917
Merged
+14
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brian Dellabetta <bdellabe@redhat.com>
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
Signed-off-by: Brian Dellabetta <bdellabe@redhat.com>
Signed-off-by: Brian Dellabetta <bdellabe@redhat.com>
brian-dellabetta
requested review from
aireilly,
dhuangnm,
dsikka and
fynnsu
and removed request for
aireilly and
dsikka
dhuangnm
previously approved these changes
Oct 13, 2025
Signed-off-by: Brian Dellabetta <bdellabe@redhat.com>
aireilly
approved these changes
Oct 13, 2025
kylesayrs
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
Linkspector is currently failing to catch broken links. After a slight update to the action yaml, errors are appropriately being logged and the check goes red if markdown links are broken. I also fixed any broken links reported by linkspector
Follow-up to #1911
TEST PLAN:
Prior to this PR, a number of links are broken. For example, click QuipModifier link on this page and it will 404. linkspector now catches these, example error readout can be found in these logs.
I updated all of broken links so it is green now, click QuipModifier on this page and it will resolve now