Skip to content

Conversation

@juliobguedes
Copy link
Contributor

What is the purpose of this pull request?

As requested in #1245, the goal of this PR is to display the URL that will be opened in the browser to allow the user to open it manually in case of errors.

What problem is this solving?

Some users using Unix distributions were not able to login using vtex login because the open and opn packages do not work properly in their OSs.

How should this be manually tested?

  1. Add the .vtex/dev/bin folder to the PATH, as mentioned in the CONTRIBUTING file;
  2. run yarn watch in the root folder of the repository
  3. run vtex-test login
  4. see the url

Screenshots or example usage

Screenshot 2025-04-30 at 15 27 40

Types of changes

  • Refactor (non-breaking change that only makes the code better)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

Chores checklist

  • Update CHANGELOG.md

@juliobguedes juliobguedes self-assigned this Apr 30, 2025
@juliobguedes
Copy link
Contributor Author

WIP: Still adding tests

Copy link
Contributor

@daniyelnnr daniyelnnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works fine here!

Copy link
Contributor

@silvadenisaraujo silvadenisaraujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juliobguedes juliobguedes merged commit d95bbb5 into main May 19, 2025
5 checks passed
@juliobguedes juliobguedes deleted the julio/log-browser-url branch May 19, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants