Skip to content

fix(a11y): ensure aria-expanded is always present by converting to st… #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(a11y): ensure aria-expanded is always present by converting to st… #445

wants to merge 1 commit into from

Conversation

jjagutzke
Copy link

…ring

@jjagutzke
Copy link
Author

Issue
The aria-expanded attribute was missing from the combobox element when isOpen was false, which caused accessibility issues. Without it, screen readers couldn't determine whether the dropdown was open or closed.

Fix
Added aria-expanded="false" to the div with role="combobox".

This improves screen reader support and aligns the implementation with ARIA best practices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jjagutzke