Skip to content

Conversation

potato4d
Copy link
Member

This pull-request is a part of #20

Changes

  • reviewer config now use env vars instead of hard coding

Copy link
Member

@re-fort re-fort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💬 しました!

}
)

let reviewers = process.env.REVIEWERS.split(',') || 're-fort,kazupon,potato4d'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

こっちのほうがよさそうかな、と!

const reviewers = process.env.REVIEWERS.split(',') || []

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

確かに 🙇

if (!pullRequest) return
Utility.log('S', `Created new pull request: ${pullRequest.html_url}`)
await github.assignReviewers(remote, { number: pullRequest.number, reviewers: ['re-fort', 'kazupon', 'potato4d'] })
await github.assignReviewers(remote, { number: pullRequest.number, reviewers: reviewers })
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

みたいな感じかなと

if (reviewers.length > 0) {
  await github.assignReviewers(remote, { number: pullRequest.number, reviewers })
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants