refactor(compiler-vapor): skip unnecessary attribute quoting in templates #13673

mary-ext · 2025-07-21T07:50:39Z

This PR alters the template generation in Vapor compiler to omit unnecessary quoting of attribute values and inclusion of whitespace between attributes, which when combined with #13667 can save a decent amount of bytes

Vue template	Generated template
`<div id="foo" class="bar"></div>`	`<div id=foo class=bar></div>`
`<div id="foo>bar" class="has whitespace"></div>`	`<div id="foo>bar"class="has whitespace"></div>`

coderabbitai · 2025-07-21T07:50:47Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

netlify · 2025-07-21T07:56:10Z

❌ Deploy Preview for vue-sfc-playground failed. Why did it fail? →

Name	Link
🔨 Latest commit	`0be562e`
🔍 Latest deploy log	https://app.netlify.com/projects/vue-sfc-playground/deploys/687df29412f43e000865bf79

mary-ext · 2025-07-21T08:19:57Z

packages/compiler-vapor/src/transforms/transformElement.ts

+          needsQuoting = /[\s>]|^["'=]/.test(value)
+
+          if (needsQuoting) {
+            const encoded = value.replace(/"/g, '&#34;')


This is a partial fix for value='"foo"' being turned into value=""foo"", I don't think this is the way to do it though, especially since this doesn't escape & as well.

I've looked into how Vue compiler deals with entities and it seems that we only ever do decoding (which makes sense for the original compiler, but it seems bad for Vapor where we generate HTML templates, we don't want static HTML code examples to be parsed as anything but text)

mary-ext · 2025-07-21T08:21:02Z

packages/compiler-vapor/src/transforms/transformElement.ts

+          // https://html.spec.whatwg.org/multipage/introduction.html#intro-early-example
+          needsQuoting = /[\s>]|^["'=]/.test(value)


I've noticed that the browser diverges slightly from the specification here, the backticks and open angled bracket aren't something browser parsers cares about, and single/double quotes only matters if it's at the start of the value.

This can be tested on the console:

template = document.createElement('template'); template.innerHTML = '<div data-backticks=`good data-end-quote=good" data-open-bracket=<good></div>'; template.innerHTML;

Let me know if we should just align to what the specification says, or to add a note that we're diverging and matching the browser.

When you say "the browser" have you tested that that works in ALL browsers? If not then it would be better to follow the spec to avoid breaking things.

yes, works fine in Gecko, WebKit and Blink. I can't test in Ladybird and Servo at the moment but I'd be surprised if it doesn't. this seems like one of those implementation-level quirk that ends up getting reimplemented across browsers, either that or this quirk is actually documented elsewhere and not on the page I referenced

This behavior is not directly tested by WPT, but they pull some tests from html5lib which has (among the tests not included in WPT at this time) tests for these quirks, which seem to indicate that it's invalid but tokenized properly (and therefore likely to gracefully be accepted by browsers as-is). https://github.com/html5lib/html5lib-tests/blob/a9f44960a9fedf265093d22b2aa3c7ca123727b9/tokenizer/test3.test#L10461-L10466

While it's not as convincing as it could be given the fact it's not pulled by WPT, Servo does uses them

edison1105 · 2025-07-25T03:45:55Z

Thanks for your PR, it looks great. I think it should add some runtime tests in dom/template.spec.ts to verify these changes work as expected.

…ates

mary-ext · 2025-07-25T07:04:17Z

Let me know if these should just be two separate test cases

edison1105 added the scope: vapor related to vapor mode label Jul 21, 2025

mary-ext commented Jul 21, 2025

View reviewed changes

edison1105 added this to Next Minor Jul 21, 2025

edison1105 moved this to Vapor in Next Minor Jul 21, 2025

mary-ext commented Jul 21, 2025

View reviewed changes

edison1105 added the need test The PR has missing test cases. label Jul 25, 2025

mary-ext added 5 commits July 25, 2025 13:54

refactor(compiler-vapor): skip unnecessary attribute quoting in templ…

083c084

…ates

refactor(compiler-vapor): skip unnecessary whitespace between attributes

2fe9c1c

fix(compiler-vapor): unset needsQuoting if there is no value

0b5b4ca

fix(compiler-vapor): encode quotes back

3e90f4e

chore(compiler-vapor): add runtime test for attribute parsing behavior

ba9cd1c

mary-ext force-pushed the omit-attribute-quoting branch from b443817 to ba9cd1c Compare July 25, 2025 07:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

refactor(compiler-vapor): skip unnecessary attribute quoting in templates #13673

refactor(compiler-vapor): skip unnecessary attribute quoting in templates #13673

mary-ext commented Jul 21, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Jul 21, 2025 •

edited

Loading

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

netlify bot commented Jul 21, 2025

Uh oh!

mary-ext Jul 21, 2025 •

edited

Loading

Uh oh!

mary-ext Jul 21, 2025 •

edited

Loading

Uh oh!

absidue Jul 21, 2025

Uh oh!

mary-ext Jul 21, 2025 •

edited

Loading

Uh oh!

cyyynthia Jul 23, 2025

Uh oh!

edison1105 commented Jul 25, 2025

Uh oh!

mary-ext commented Jul 25, 2025

Uh oh!

Uh oh!

		// https://html.spec.whatwg.org/multipage/introduction.html#intro-early-example
		needsQuoting = /[\s>]\|^["'=]/.test(value)

Uh oh!

refactor(compiler-vapor): skip unnecessary attribute quoting in templates #13673

Are you sure you want to change the base?

refactor(compiler-vapor): skip unnecessary attribute quoting in templates #13673

Conversation

mary-ext commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

netlify bot commented Jul 21, 2025

❌ Deploy Preview for vue-sfc-playground failed. Why did it fail? →

Uh oh!

mary-ext Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mary-ext Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

absidue Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

mary-ext Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cyyynthia Jul 23, 2025

Choose a reason for hiding this comment

Uh oh!

edison1105 commented Jul 25, 2025

Uh oh!

mary-ext commented Jul 25, 2025

Uh oh!

Uh oh!

mary-ext commented Jul 21, 2025 •

edited

Loading

coderabbitai bot commented Jul 21, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

mary-ext Jul 21, 2025 •

edited

Loading

mary-ext Jul 21, 2025 •

edited

Loading

mary-ext Jul 21, 2025 •

edited

Loading