-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
feat: add navigation-api router #2551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for vue-router canceled.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2551 +/- ##
===========================================
- Coverage 94.80% 71.10% -23.71%
===========================================
Files 34 39 +5
Lines 3004 4094 +1090
Branches 846 851 +5
===========================================
+ Hits 2848 2911 +63
- Misses 153 1180 +1027
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
chore: fix route paths logic
…n tsdoc-plugin-md (4.8.1)
Maybe we can use a vue plugin for |
arggg, back/forward view transitions broken, reviewing code |
Right now I'm playing with it, once the features added we can start adding compatibility.
Looks like I've finished it, will need to review view transitions at legacy router an prepare some tests here: will port #2552 PR to this PR to add some tests and a new playground.
You can play with the new Navigation API Router in my GH repo using this branch: https://github.com/userquin/vue-router-api/tree/nav-api-vue-router