Skip to content

Conversation

userquin
Copy link
Member

@userquin userquin commented Sep 12, 2025

Right now I'm playing with it, once the features added we can start adding compatibility.

Looks like I've finished it, will need to review view transitions at legacy router an prepare some tests here: will port #2552 PR to this PR to add some tests and a new playground.

You can play with the new Navigation API Router in my GH repo using this branch: https://github.com/userquin/vue-router-api/tree/nav-api-vue-router

Copy link

netlify bot commented Sep 12, 2025

Deploy Preview for vue-router canceled.

Name Link
🔨 Latest commit 11632e0
🔍 Latest deploy log https://app.netlify.com/projects/vue-router/deploys/68cb29b88fa4900008112974

Copy link
Contributor

coderabbitai bot commented Sep 12, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

pkg-pr-new bot commented Sep 12, 2025

Open in StackBlitz

npm i https://pkg.pr.new/vue-router@2551

commit: 11632e0

Copy link

codecov bot commented Sep 12, 2025

Codecov Report

❌ Patch coverage is 7.89238% with 1027 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.10%. Comparing base (6171856) to head (11632e0).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
packages/router/src/navigation-api/index.ts 0.25% 781 Missing ⚠️
packages/router/src/router.ts 20.47% 101 Missing ⚠️
packages/router/src/focus.ts 4.81% 79 Missing ⚠️
packages/router/src/utils/routes.ts 13.51% 32 Missing ⚠️
packages/router/src/modern-router-factory.ts 8.33% 22 Missing ⚠️
packages/router/src/navigationGuards.ts 76.74% 10 Missing ⚠️
packages/router/src/transition.ts 71.42% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2551       +/-   ##
===========================================
- Coverage   94.80%   71.10%   -23.71%     
===========================================
  Files          34       39        +5     
  Lines        3004     4094     +1090     
  Branches      846      851        +5     
===========================================
+ Hits         2848     2911       +63     
- Misses        153     1180     +1027     
  Partials        3        3               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@userquin
Copy link
Member Author

userquin commented Sep 15, 2025

Maybe we can use a vue plugin for enableViewTransition, this way Nuxt can register the plugin (its current plugin can be simplified a lot with latest features added here)

@userquin
Copy link
Member Author

userquin commented Sep 17, 2025

arggg, back/forward view transitions broken, reviewing code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant