Skip to content

docs: suggest using section instead of div for card component #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

docs: suggest using section instead of div for card component #171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dc874e1
docs: suggest using `section` instead of `div` for card component
jguddas Feb 1, 2025
86f4cff
Update card-link-single.html.twig
jguddas Feb 1, 2025
8cbc87d
Update card-simple-icon.html.twig
jguddas Feb 1, 2025
7cda09f
Update card-simple-image.html.twig
jguddas Feb 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions design-system-templates/components/card-link-multiple.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<div class="event-list">
<div class="card card--event meeting" data-component="card" data-anchor="no">
<section class="card card--event meeting" data-component="card" data-anchor="no">
<div class="card__text">
<div class="l-sidebar">
<div>
Expand All @@ -23,5 +23,5 @@
<p class="txt-pluto"><a href="path/to/category">Category link</a></p>
<p class="txt-pluto">Meeting</p>
</div>
</div>
</div>
</section>
</div>
4 changes: 2 additions & 2 deletions design-system-templates/components/card-link-single.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<div class="card" data-component="card">
<section class="card" data-component="card">
<div class="card__text">
<h3 class="card__heading"><a href="path/to/page" class="card__link">W3C starts web payments standards work</a></h3>
<p>New working group launched to make payments easier and more secure.</p>
Expand All @@ -11,4 +11,4 @@
loading="lazy"
alt="A Macbook screen with code, as seen from over the developer's shoulder" />
</div>
</div>
</section>
4 changes: 2 additions & 2 deletions design-system-templates/components/card-simple-icon.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<div class="card">
<section class="card">
<div class="card__text">
<h3 class="card__heading">Web Design and Applications</h3>
<p>The standards for building and Rendering Web pages, including HTML, CSS, SVG, Ajax, and other technologies for Web Applications (“WebApps”). Includes information on how to make pages accessible (WCAG), to internationalize them, and make them work on mobile devices.</p>
<a href="path/to/page"><span class="visuallyhidden">Web Design and Applications</span> Learn more</a>
</div>
<svg class="icon icon--larger" xmlns="http://www.w3.org/2000/svg" focusable="false" aria-hidden="true" viewBox="0 0 512 512" width="1em" height="1em"><defs/><path d="M204.3 5C104.9 24.4 24.8 104.3 5.2 203.4c-37 187 131.7 326.4 258.8 306.7 41.2-6.4 61.4-54.6 42.5-91.7-23.1-45.4 9.9-98.4 60.9-98.4h79.7c35.8 0 64.8-29.6 64.9-65.3C511.5 97.1 368.1-26.9 204.3 5zM96 320c-17.7 0-32-14.3-32-32s14.3-32 32-32 32 14.3 32 32-14.3 32-32 32zm32-128c-17.7 0-32-14.3-32-32s14.3-32 32-32 32 14.3 32 32-14.3 32-32 32zm128-64c-17.7 0-32-14.3-32-32s14.3-32 32-32 32 14.3 32 32-14.3 32-32 32zm128 64c-17.7 0-32-14.3-32-32s14.3-32 32-32 32 14.3 32 32-14.3 32-32 32z"/></svg>
</div>
</section>
4 changes: 2 additions & 2 deletions design-system-templates/components/card-simple-image.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<div class="card">
<section class="card">
<div class="card__text">
<h3 class="card__heading">W3C starts web payments standards work</h3>
<p>New working group launched to make payments easier and more secure.</p>
Expand All @@ -11,4 +11,4 @@
loading="lazy"
alt="A Macbook screen with code, as seen from over the developer's shoulder" />
</div>
</div>
</section>