Element in-view: Fix circular definition #1918
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Euclid Ye <euclid.ye@huawei.com>
yezhizhen
force-pushed
the
fix-circular-definition
branch
from
dabf8af to
2850417
Compare
|
cc @xiaochengh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the definition of element is in-view needs to compute pointer-interactive paint tree, whose step 4 computes in-view center point, which again requires element is in-view!
But actually we can safely remove the in-view requirement of in-view center point, as step 5 of compute pointer-interactive paint tree feed center point to elementsFromPoint, which simply return a empty sequence if input is not in viewport.
As a result, we have empty pointer-interactive paint tree meaning that element is not in-view.
Preview | Diff