Skip to content

WIP: replace register-alloc with purely stack-based translation #1512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 162 commits into
base: main
Choose a base branch
from
Draft

WIP: replace register-alloc with purely stack-based translation #1512

wants to merge 162 commits into from

Conversation

Robbepop
Copy link
Member

Closes #1484.

@Robbepop Robbepop changed the title Replace register-alloc with purely stack-based translation WIP: replace register-alloc with purely stack-based translation May 10, 2025
@codecov Codecov
Copy link

codecov bot commented May 10, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 3.75361% with 1000 lines in your changes missing coverage. Please review.

Project coverage is 67.72%. Comparing base (57b28e7) to head (8cea35b).

Files with missing lines Patch % Lines
...es/wasmi/src/engine/translator/func2/simd/visit.rs 0.00% 256 Missing ⚠️
crates/wasmi/src/engine/translator/func2/visit.rs 0.00% 213 Missing ⚠️
...wasmi/src/engine/translator/func2/stack/control.rs 0.00% 115 Missing ⚠️
...asmi/src/engine/translator/func2/stack/operands.rs 0.00% 115 Missing ⚠️
...tes/wasmi/src/engine/translator/func2/stack/mod.rs 0.00% 87 Missing ⚠️
crates/wasmi/src/engine/translator/func2/mod.rs 0.00% 62 Missing ⚠️
...wasmi/src/engine/translator/func2/stack/operand.rs 0.00% 46 Missing ⚠️
...es/wasmi/src/engine/translator/func2/layout/mod.rs 0.00% 37 Missing ⚠️
...wasmi/src/engine/translator/func2/layout/consts.rs 0.00% 32 Missing ⚠️
crates/wasmi/src/engine/translator/func2/instrs.rs 0.00% 17 Missing ⚠️
... and 3 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1512      +/-   ##
==========================================
- Coverage   71.75%   67.72%   -4.03%     
==========================================
  Files         179      191      +12     
  Lines       16524    17563    +1039     
==========================================
+ Hits        11856    11895      +39     
- Misses       4668     5668    +1000

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Robbepop Robbepop force-pushed the rf-stack-based-translation branch from 3d12a1f to 01dceaa Compare May 11, 2025 18:59
@Robbepop Robbepop force-pushed the rf-stack-based-translation branch 3 times, most recently from 74cea23 to 90148db Compare June 3, 2025 09:09
@Robbepop Robbepop mentioned this pull request Jun 5, 2025
Merged
@Robbepop Robbepop force-pushed the rf-stack-based-translation branch 4 times, most recently from c8fedbe to 5f7b15e Compare June 8, 2025 20:52
@Robbepop Robbepop mentioned this pull request Jun 12, 2025
Merged
@Robbepop Robbepop force-pushed the rf-stack-based-translation branch from 90c0633 to 9710ce5 Compare June 12, 2025 17:32
@Robbepop Robbepop mentioned this pull request Jun 13, 2025
Merged
@Robbepop Robbepop force-pushed the rf-stack-based-translation branch 3 times, most recently from 49c874b to f5593b5 Compare June 15, 2025 09:52
@Robbepop Robbepop mentioned this pull request Jun 15, 2025
Merged
Robbepop added 18 commits June 16, 2025 00:18
@Robbepop
implement FuncTranslator::visit_block trait method
2b79d07
@Robbepop
implement FuncTranslator::visit_loop trait method
3a9e967
@Robbepop
reorder exports
6330a16
@Robbepop
push else operands only for IfReachability::Both
0a34bc4 
Otherwise a Wasm `if` acts similar to a Wasm `block` since it is known upfront that operands are not required to be input twice.
@Robbepop
start implementation of FuncTranslator::visit_if
77d2711
@Robbepop
convert condition operand to Reg
a1034fb
@Robbepop
fix some internal doc links
97aa81f
@Robbepop
make InstrEncoder::get_mut private
eac68d5
@Robbepop
fix compile error
d58b07b
@Robbepop
silence warnings temporarily for visit_if
71c130d
@Robbepop
remove Reset impl for InstrEncoder
7bc5785 
This impl is just needed for *Allocation types such as InstrEncoderAllocations.
@Robbepop
add last_instr field to InstrEncoder
57259da
@Robbepop
add (debug) asserts for is_instruction_parameter
86c5f29
@Robbepop
add AllocConst impl for StackLayout
b270687 
This allows to use StackLayout as parameter to try_into_cmp_branch_instr ext-trait method.
@Robbepop
add InstrEncoder::try_replace_instr method
db99d68
@Robbepop
implement translate_br_if variants + fusion
67c437f
@Robbepop
implement visit_if
882ffb4
@Robbepop
fix bug in translate_br_if fallback
459e162
@Robbepop Robbepop force-pushed the rf-stack-based-translation branch from f5593b5 to 459e162 Compare June 16, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wasmi translator: replace register alloc with stack walker
1 participant
@Robbepop