-
-
Notifications
You must be signed in to change notification settings - Fork 59
feat: support JSX preserve #1244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bf62cad
to
54ab649
Compare
I see |
@GRAMMAC1 |
@GRAMMAC1 i made a mistake. I just noticed that version 1.4.1 has shipped the commit this PR relies on. i will push this PR for merging now. |
54ab649
to
28ed0fc
Compare
✅ Deploy Preview for rslib ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
28ed0fc
to
c8e9d7b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements support for JSX preserve functionality in rslib, adding the ability to keep native JSX syntax in build outputs for further processing by other tools. This is the final step following a previous related PR.
- Adds JSX preserve runtime support with bundleless mode requirement
- Updates documentation to include the new
'preserve'
option and usage examples - Includes comprehensive test coverage for the new functionality
Reviewed Changes
Copilot reviewed 43 out of 44 changed files in this pull request and generated 4 comments.
Show a summary per file
File | Description |
---|---|
website/docs/*/guide/solution/react.mdx | Updated documentation to include JSX preserve option and usage examples |
packages/core/src/config.ts | Added bundle validation plugin and JSX file extension support for minification |
tests/integration/preserve-jsx/ | Added comprehensive test suite for JSX preserve functionality |
tests/scripts/shared.ts | Extended file pattern matching to include .jsx files |
Multiple package.json files | Updated @rsbuild/plugin-react dependency version to ^1.4.1 |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
@copilot Write a summary which similar to a release note. |
@copilot Write a summary which similar to a release note. |
@codex Write a summary which similar to a release note. |
Summary
Testing
|
Highlights 💡
Preserve JSX
Rslib supports setting the JSX runtime to 'preserve' to leave JSX syntax unchanged without transforming it, which is useful when you expect JSX to be left as is in library development.
Summary
third(final) step after web-infra-dev/rsbuild#6240.
Related Links
Checklist