V2 6603 #12
Open
V2 6603 #12
+156,840
−482,128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dargon789
commented
Apr 27, 2025
Dargon789
commented
- Because this PR includes a bug fix, relevant tests have been included.
- Because this PR includes a new feature, the change was previously discussed on an Issue or with someone from the team.
- I didn't do anything of this.
…#832) * fix: add additional validation for global parameters Default values for parameters masked the test cases for our global parameters feature. This commit adds additional tests for parameters without default values and enhances the validations to support Global Parameters as an option. * fix: use global params where other module params exist If there is a parameter defined in Global parameters, and a different parameter defined at the module level, we were failing to find the global parameter. This has been fixed with a more explicit lookup in `resolveModuleParameter`. Two tests have been added to check module param lookup where a different global parameter exists, and global parameter lookup where a different module parameter exists. * refactor: pull out shared validation code Pull out the shared validation resolution code for module/global/default value resolution for module parameters. Fixes NomicFoundation#834
To ensure we work with nested parameters we use a replacer function on stringify, rather than swapping out individual params.
Update the packages versions and changelogs for the `0.15.8 - 2024-11-22` release.
Added pnpm to tabgroup
Using `--save-dev` keeps it closer to the other install commands.
…etion.md Co-authored-by: Patricio Palladino <email@patriciopalladino.com>
* Add plugin hardhat-tx-decoder and fix typo * Fix prettier Signed-off-by: Axel Loupias <26647479+AxelLoupias@users.noreply.github.com>
* feat: adds --output to flatten * fix: adds temporary file * chore: clean up after failed flatten test run * docs: add a changeset for the new --output param --------- Co-authored-by: John Kane <john@kanej.me> Co-authored-by: Piotr Galar <piotr.galar@gmail.com>
…ficulty Make totalDifficulty field optional, as spec has changed.
* Update README.md * Update oracles.md * Update reference.md
* Update info.md * Update docs/temp/info.md --------- Co-authored-by: John Kane <john@kanej.me>
* Update test-contracts.md * Update docs/src/content/hardhat-runner/docs/guides/test-contracts.md --------- Co-authored-by: John Kane <john@kanej.me>
…NomicFoundation#6011) * typos using-viem.md * typos formatting.md
* Update deploying.md * Update README.md
Fix Broken Link
…/missing-features-docs Add reference docs for CLI commands
…/module-after-fix Resolve all dependencies when using submodules in `after`
…/arbitrum-sepolia Add arbitrum sepolia to chain config
…umberjs-types Fix compilation error with bignumber.js latest types
…umber-js-latest-types-chai-matchers Fix compilation error with bignumber.js latest types
* feat: display hh 3 beta banner on project creation and task run * fix: increase timeout and switch to actual URL * feat: add caching * docs: add changeset * fix: skip showBanner logic when no messages are configured * refactor: rename variables and file for broader/generic usage * refactor: hide request logic * refactor: add logging * refactor: rename * fix: throw error on invalid status code * refactor: rename variable
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 5.4.11 to 5.4.17. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/v5.4.17/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v5.4.17/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-version: 5.4.17 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
…ot/npm_and_yarn/vite-5.4.17 Bump vite from 5.4.11 to 5.4.17
Fix broken link
Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com>
…ain permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com>
…ain permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com>
…ain permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com>
…ain permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com>
…ain permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com>
…ain permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com>
…ain permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com>
…ain permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.