chore: upgrade eslint from v8 to v9

package.json

@@ -65,7 +65,7 @@
     "@types/node": "^18.15.11",
     "@webpack-contrib/eslint-config-webpack": "^3.0.0",
     "babel-jest": "^28.1.3",
-    "bootstrap": "^4.6.2",
+    "bootstrap": "^5.3.7",
     "cross-env": "^7.0.3",
     "cspell": "^6.31.1",
     "css-loader": "^6.10.0",
@@ -80,7 +80,7 @@
     "jest": "^28.1.3",
     "jest-environment-jsdom": "^28.1.3",
     "jsdom": "^19.0.0",
-    "lint-staged": "^13.2.1",
+    "lint-staged": "^16.1.2",
     "memfs": "^3.4.13",
     "npm-run-all": "^4.1.5",
     "prettier": "^2.8.7",
@@ -90,7 +90,7 @@
     "typescript": "^4.9.5",
     "webpack": "^5.91.0",
     "webpack-cli": "^4.9.2",
-    "webpack-dev-server": "^4.13.2"
+    "webpack-dev-server": "^5.2.2"
   },
   "keywords": [
     "webpack",

src/index.js

@@ -291,7 +291,7 @@ class MiniCssExtractPlugin {
       /**
        * @private
        * @param {string} hashFunction
-       * @returns {string | Buffer}
+       * @returns {string}
        */
       _computeHash(hashFunction) {
         const hash = webpack.util.createHash(hashFunction);
@@ -306,7 +306,7 @@ class MiniCssExtractPlugin {
         hash.update(this.media || "");
         hash.update(this.sourceMap || "");
 
-        return hash.digest("hex");
+        return /** @type {string} */ (hash.digest("hex"));
       }
 
       /**
@@ -316,9 +316,12 @@ class MiniCssExtractPlugin {
       updateHash(hash, context) {
         super.updateHash(hash, context);
 
-        hash.update(
-          /** @type {NonNullable<Module["buildInfo"]>} */ (this.buildInfo).hash
-        );
+        const buildInfoHash = /** @type {NonNullable<Module["buildInfo"]>} */ (
+          this.buildInfo
+        ).hash;
+        if (buildInfoHash) {
+          hash.update(buildInfoHash);
+        }
       }
 
       /**

src/loader.js

@@ -458,12 +458,12 @@ function pitch(request) {
         (loaderContext, module) => {
           if (module.request === request) {
             // eslint-disable-next-line no-param-reassign
-            module.loaders = loaders.map((loader) => {
+            module.loaders = loaders.map((loaderItem) => {
               return {
                 type: null,
-                loader: loader.path,
-                options: loader.options,
-                ident: loader.ident,
+                loader: loaderItem.path,
+                options: loaderItem.options,
+                ident: loaderItem.ident,
               };
             });
           }

src/utils.js

@@ -236,10 +236,11 @@ const quoteMeta = (str) => str.replace(/[-[\]\\/{}()*+?.^$|]/g, "\\$&");
  * @returns {string} common prefix
  */
 const getCommonPrefix = (items) => {
-  let prefix = items[0];
+  const [firstItem, ...restItems] = items;
+  let prefix = firstItem;
 
-  for (let i = 1; i < items.length; i++) {
-    const item = items[i];
+  for (let i = 0; i < restItems.length; i++) {
+    const item = restItems[i];
     for (let p = 0; p < prefix.length; p++) {
       if (item[p] !== prefix[p]) {
         prefix = prefix.slice(0, p);
@@ -256,10 +257,11 @@ const getCommonPrefix = (items) => {
  * @returns {string} common suffix
  */
 const getCommonSuffix = (items) => {
-  let suffix = items[0];
+  const [firstItem, ...restItems] = items;
+  let suffix = firstItem;
 
-  for (let i = 1; i < items.length; i++) {
-    const item = items[i];
+  for (let i = 0; i < restItems.length; i++) {
+    const item = restItems[i];
     for (let p = item.length - 1, s = suffix.length - 1; s >= 0; p--, s--) {
       if (item[p] !== suffix[s]) {
         suffix = suffix.slice(s + 1);
@@ -285,7 +287,7 @@ const popCommonItems = (itemsSet, getKey, condition) => {
     const key = getKey(item);
     if (key) {
       let list = map.get(key);
-      if (list === undefined) {
+      if (!list) {
         /** @type {Array<string>} */
         list = [];
         map.set(key, list);
@@ -358,7 +360,7 @@ const itemsToRegexp = (itemsArr) => {
 
     if (prefix.length > 0 || suffix.length > 0) {
       return `${quoteMeta(prefix)}${itemsToRegexp(
-        itemsArr.map((i) => i.slice(prefix.length, -suffix.length || undefined))
+        itemsArr.map((i) => i.slice(prefix.length, -suffix.length || 0))
       )}${quoteMeta(suffix)}`;
     }
   }

test/cases/new-url/index.js

@@ -1,3 +1,3 @@
+// Test URL creation
 const myURL = new URL("./style.css", import.meta.url);
-
-console.log(myURL);
+export default myURL;

test/manual/src/worker.js

@@ -1,9 +1,7 @@
 import "./worker.css";
 
 // eslint-disable-next-line no-undef
-self.onmessage = (event) => {
-  console.log(`Received message from application: ${event.data}`);
-
+self.onmessage = () => {
   // eslint-disable-next-line no-undef
   self.postMessage("I'm alive!");
 };

test/manual/webpack.config.js

@@ -14,11 +14,6 @@ const ENABLE_ES_MODULE =
 const OLD_API =
   typeof process.env.OLD_API !== "undefined" ? yn(process.env.OLD_API) : false;
 
-console.log("OPTIONS:");
-console.log("ENABLE_HMR:", ENABLE_HMR);
-console.log("ENABLE_ES_MODULE:", ENABLE_ES_MODULE);
-console.log("OLD_API:", OLD_API);
-
 module.exports = {
   devtool: false,
   mode: "development",