Async Fetch Refactor #880
Open
Async Fetch Refactor #880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ikreymer
commented
Aug 25, 2025
ikreymer
commented
- separate out reading stream response while browser is waiting (not really async) from actual async loading, this is not handled via fetchResponseBody()
- unify async fetch into first trying browser networking for regular GET, fallback to regular fetch()
- load headers and body separately in async fetch, allowing for cancelling request after headers
- refactor direct fetch of non-html pages: load headers and handle loading body, adding page async, allowing worker to continue loading browser-based pages (should allow more parallelization in the future)
- unify WARC writing in preparation for dedup: unified serializeWARC() called for all paths, WARC digest computed, additional checks for payload added for streaming loading
- single AsyncFetcher tries both browser + direct fetch - separate loadHeaders() and loadBody() - direct fetch page: try loadHeaders(), queue loadDirectPage() to be done async and finish page
tw4l
reviewed
Sep 2, 2025
Comment on lines
+1268
to
+1271
| // not yet finished | ||
| if (data.asyncLoading) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
I assume we'd end up here if the page worker timeout is hit (or the worker crashes) before the page has finished loading async. Is there any tidying up we want to do in that case rather than just returning?
tw4l
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.