Skip to content

fix unicode error #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix unicode error #103

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e4acd3b
fix unicode error
chencheng-meican May 11, 2024
2eb5175
code format
chencheng-meican May 11, 2024
653b8d2
Merge branch 'master' into fix/unicode-block-error
aivus Aug 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,11 @@ class PuppeteerPlugin {
await page.close();

// convert utf-8 -> binary string because website-scraper needs binary
return Buffer.from(content).toString('binary');
// https://github.com/website-scraper/node-website-scraper?tab=readme-ov-file#afterresponse: (binary) This is advised against because of the binary assumption being made can foul up saving of utf8 responses to the filesystem.
return {
body: content,
encoding: 'utf8'
Copy link
Member

@aivus aivus Aug 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@s0ph1e Should we do the same we did in website-scraper?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @azlarsin,
thank you for your contribution 👍 and sorry for the very late response from my side.

Hi @aivus,
thank you for pinging me. I think, it's a good idea to use the same approach, that already exists in the main module. It would also be nice to have some tests for it (we can use an example in the PR comment).

};
} else {
return response.body;
}
Expand Down