Fix peptide tokenizer bug when detokenizing in reverse #72
+13
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wfondrie
requested changes
May 13, 2025
Owner
wfondrie
left a comment
wfondrie
left a comment
There was a problem hiding this comment.
This looks good. Please add a unit test and it should be good to go!
Contributor
Author
|
Sounds good, I added a test. |
Lilferrit
force-pushed
the
reverse-fix
branch
from
bd4ce52 to
be77cbd
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #72 +/- ##
==========================================
- Coverage 96.71% 96.62% -0.10%
==========================================
Files 24 24
Lines 1004 1006 +2
==========================================
+ Hits 971 972 +1
- Misses 33 34 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug where when detokenizing a peptide sequence in reverse mode the entire string is reversed, leading to incorrect behavior for multi-character residues. For example the sequence
K[Oxidation]MARRAYLKgets detokenized asK]noitadixO[MARRAYLK.