Skip to content

Navigation: Add optimization to ignore duplicate navigations #11765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Navigation: Add optimization to ignore duplicate navigations #11765

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e71a959
feat(navigation): Ignore duplicate navigations
llannasatoll Oct 8, 2025
27be0e6
Refine duplicate navigation check
llannasatoll Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions source
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106290,6 +106290,45 @@ location.href = '#foo';</code></pre>
data-x="apply the traverse history step">traversing</span> are ignored.</p>
</li>

<li>
<p>If <var>navigable</var>'s <span>ongoing navigation</span> is not null, and all of the following
are true:</p>

<ul>
<li>
<p>the time elapsed since the ongoing navigation was initiated is within a
user-agent-defined threshold;</p>
</li>
<li>
<p>both the new and ongoing navigations are HTTP GET requests, and the new navigation is not
a form submission;</p>
</li>
<li>
<p>the navigations have an identical <var>url</var>, <span
data-x="document-state-initiator-origin">initiator origin</span>, <span
data-x="document-state-request-referrer">referrer</span>, <span
data-x="document-state-request-referrer-policy">request referrer policy</span>,
<var>userInvolvement</var>, and <var>historyHandling</var>;</p>
</li>
<li>
<p>the ongoing navigation's <span>active document</span>'s "navigation conditions potentially changed" flag is false,</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the "navigation conditions potentially changed" flag should be a property of the "navigable" instead of on the active document, declared here. It should be associated with the ongoing navigation, which means we set it to false whenever we set the ongoing navigation is set / reset. Then in https://html.spec.whatwg.org/multipage/dom.html#dom-document-cookie mention that setting the cookie will set the flag to false, and add a note that other cookie-setting operations such as the Cookie Store API and setting non-HTTP only cookies via fetch can also set the flag to false.

</li>
</ul>
<p>then:</p>

<ol>
<li>
<p>Invoke <span>WebDriver BiDi navigation failed</span> with <var>navigable</var> and a new
<span>WebDriver BiDi navigation status</span> whose <span
data-x="navigation-status-id">id</span> is <var>navigationId</var>, <span
data-x="navigation-status-status">status</span> is "<code
data-x="navigation-status-canceled">canceled</code>", and <span
data-x="navigation-status-url">url</span> is <var>url</var>.</p>
</li>
<li><p>Return.</p></li>
</ol>
</li>

<li>
<p><span>Set the ongoing navigation</span> for <var>navigable</var> to
<var>navigationId</var>.</p>
Expand Down