Editorial: add missing args for CreateBuiltinFunction #1539
Conversation
annevk
left a comment
annevk
left a comment
There was a problem hiding this comment.
This looks good to me. Might be good if someone else takes a look too though, maybe @Ms2ger or @saschanaz?
| 1. If |ongoingPromise| is not null, then: | ||
| 1. Let |afterOngoingPromiseCapability| be [=!=] [$NewPromiseCapability$]({{%Promise%}}). | ||
| 1. Let |onSettled| be [$CreateBuiltinFunction$](|nextSteps|, « »). | ||
| 1. Let |onSettled| be [$CreateBuiltinFunction$](|nextSteps|, 0, "", « »). |
There was a problem hiding this comment.
Why is this one 0? It seems elsewhere you default to 1.
There was a problem hiding this comment.
This is because fulfillSteps and rejectSteps each take one argument (next and reason, respectively), whereas nextSteps takes none.
|
You'll also have to complete https://participate.whatwg.org/agreement. |
When I try to submit the agreement, I get the error message: "Email is already present in the system". However, it seems that the participant data is still added to individuals.json. |
|
Oh that's weird, not sure what would have caused that as your email address does appear to be unique. |
Ms2ger
left a comment
Ms2ger
left a comment
There was a problem hiding this comment.
This seems reasonable. Are the length/name observable for any of the functions that didn't previously have them defined explicitly?
| 1. Let |F| be <a abstract-op>CreateBuiltinFunction</a>(|steps|, 0, |name|, « », |realm|). | ||
| 1. Return |F|. |
There was a problem hiding this comment.
Probably these two steps could be merged now.
| 1. Let |F| be <a abstract-op>CreateBuiltinFunction</a>(|steps|, 1, |name|, « », |realm|). | ||
| 1. Return |F|. |
There was a problem hiding this comment.
Ditto (and this would fix the inconsistent indentation too).
Co-authored-by: Ms2ger <Ms2ger@gmail.com>
Co-authored-by: Ms2ger <Ms2ger@gmail.com>
Co-authored-by: Ms2ger <Ms2ger@gmail.com>
Co-authored-by: Ms2ger <Ms2ger@gmail.com>
Co-authored-by: Ms2ger <Ms2ger@gmail.com>
3 participants
Previously,
lengthandnamearguments for CreateBuiltinFunction were missing.This PR adds them to align with the ECMAScript specification.
Preview | Diff