Skip to content

Conversation

@Isira-Seneviratne
Copy link
Contributor

@Isira-Seneviratne Isira-Seneviratne commented Aug 16, 2025

What does this do?

This change restricts the size of the search widget on Android versions below 12.

Why is this needed?

This change avoids widget sizing issues on Android versions below 12.

Phabricator:
https://phabricator.wikimedia.org/T...

@Williamrai
Copy link
Collaborator

Thanks for working on this! I appreciate the effort you've put into this solution. I think there might be a simpler approach we could try first, we can set android:minResizeWidth in the widget metadata XML to prevent resizing below this limit. This would support all API levels, require fewer code changes, and avoid adding another dependency. What do you think about trying that approach?

@Isira-Seneviratne
Copy link
Contributor Author

Thanks for working on this! I appreciate the effort you've put into this solution. I think there might be a simpler approach we could try first, we can set android:minResizeWidth in the widget metadata XML to prevent resizing below this limit. This would support all API levels, require fewer code changes, and avoid adding another dependency. What do you think about trying that approach?

Sure, the XML could be overriden for API levels 31 and later.

@Isira-Seneviratne Isira-Seneviratne changed the title Backport dynamic layout for search widget Restrict width for search widget on Android versions below 12 Sep 15, 2025
@Williamrai
Copy link
Collaborator

Thanks for working on this! I appreciate the effort you've put into this solution. I think there might be a simpler approach we could try first, we can set android:minResizeWidth in the widget metadata XML to prevent resizing below this limit. This would support all API levels, require fewer code changes, and avoid adding another dependency. What do you think about trying that approach?

Sure, the XML could be overriden for API levels 31 and later.

Thanks again for taking the time to make these updates. I think we may not need the xml-v31 override for this fix. Adding android:minResizeWidth in the base XML should apply correctly across all API levels, so the extra version-specific file might not be necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants