Add exists option to ProductSearch Result for matching other search types #641
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
Please open an issue so it can go through triage for approval. |
| case BURN_MSI_PRODUCT_SEARCH_TYPE_LANGUAGE: | ||
| type = BURN_VARIANT_TYPE_STRING; | ||
| break; | ||
| case BURN_MSI_PRODUCT_SEARCH_TYPE_EXISTS: __fallthrough; |
There was a problem hiding this comment.
Rather than fall through here and check the type again below (line 1255), we should just set the value appropriately in this case.
There was a problem hiding this comment.
The value is in this stage string format?
There was a problem hiding this comment.
Do you want me to anything with this commit?
I am not using existing case because at this point the value is string and later converted to int.
hr = WiuGetProductInfo(sczGuid, wzProperty, &value.sczValue);
...
hr = BVariantChangeType(&value, type);
and then int value is compared
value.llValue = (value.llValue == INSTALLSTATE_ABSENT) ? 0 : 1;
src/burn/engine/search.cpp
Outdated
|
|
||
| if (BURN_MSI_PRODUCT_SEARCH_TYPE_EXISTS == pSearch->MsiProductSearch.Type) | ||
| { | ||
| value.llValue = value.llValue == INSTALLSTATE_ABSENT ? 0 : 1; |
There was a problem hiding this comment.
I'd like to see parens around the ternary condition:
value.llValue = (value.llValue == INSTALLSTATE_ABSENT) ? 0 : 1;
And moved up to the correct case. :)
There was a problem hiding this comment.
Isn't the value before BVariantChangeType string type?
metsma
force-pushed
the
ProductSearchExists
branch
from
118c8b6 to
a5496b4
Compare
(e.g. FileSearch, DirectorySearch, RegistrySearch) Signed-off-by: Raul Metsma <raul@metsma.ee>
metsma
force-pushed
the
ProductSearchExists
branch
from
a5496b4 to
17b965b
Compare
(e.g. FileSearch, DirectorySearch, RegistrySearch)
Closes wixtoolset/issues#9079
Signed-off-by: Raul Metsma raul@metsma.ee