perf: optimize Day component re-renders for single date selection #995
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Problem
When selecting dates, all Day and Tile components (~60 total) re-render unnecessarily, causing performance issues especially on mobile devices.
💡 Solution
React.memo
with custom comparison that only re-renders when selection state changes📊 Performance Impact
✅ Backward Compatibility
🧪 Testing
Files changed:
src/Calendar.tsx
: Early return after value computationsrc/MonthView/Day.tsx
: React.memo with custom comparisonsrc/MonthView/Days.tsx
: Pass value prop to Day componentsReady for review! 🚀