fix: Mitigate Android text composition oddities #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forcibly ending text composition led to odd outcomes--e.g., erroneously dismissing the inline inserter, resetting editor history stack. It was originally added to ensure the latest text in the editor is captured before providing it to the host app for persistence. This appears necessary for Samsung device keyboards only. For the time being, text may be lost on these devices if the user does not first blur the text input before saving or exiting the editor.
dcalhoun
requested review from
nbradbury and
adalpari
and removed request for
nbradbury
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Remove default of ending text composition when requesting title and content.
Related: wordpress-mobile/WordPress-Android#21883
Why?
Ref CMM-353. Ref CMM-199.
Fix #103. Fix #130.
Forcibly ending text composition led to odd outcomes--e.g., erroneously
dismissing the inline inserter, resetting editor history stack.
It was originally added to ensure the latest text in the editor is
captured before providing it to the host app for persistence. This
appears necessary for Samsung device keyboards only. For the time being,
text may be lost on these devices if the user does not first blur the
text input before saving or exiting the editor.
How?
Flip the default parameter value.
Testing Instructions
See wordpress-mobile/WordPress-Android#21883.
Accessibility Testing Instructions
N/A, no navigation changes.
Screenshots or screencast
N/A, no visual changes.