Skip to content

Update wordpress-rs to trunk-db86370a4ce7ae45e210e57a0403cc70ce70f167 #21868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from

Conversation

oguzkocer
Copy link
Contributor

@oguzkocer oguzkocer commented May 12, 2025

Updates wordpress-rs to the latest trunk version. We have a few other changes coming up related to Android, so I didn't do a new alpha build for this as there is no difference between alpha tags and the published trunk version.

I've also updated jna to the latest 5.17.0 version because that's what wordpress-rs uses and if I am not mistaken jna is only used for wordpress-rs at the moment. (it might also be used by gutenberg-mobile I am not sure)

To Test

  • Smoke test a simple post with the block editor just in case

@oguzkocer oguzkocer added this to the 25.9 milestone May 12, 2025
@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 12, 2025

Project dependencies changes

list
! Upgraded Dependencies
rs.wordpress.api:android:trunk-db86370a4ce7ae45e210e57a0403cc70ce70f167, (changed from alpha-20250411)
rs.wordpress.api:kotlin:trunk-db86370a4ce7ae45e210e57a0403cc70ce70f167, (changed from alpha-20250411)
tree
 +--- project :libs:fluxc
-|    \--- net.java.dev.jna:jna:5.15.0 -> 5.17.0
+|    \--- net.java.dev.jna:jna:5.17.0
-\--- rs.wordpress.api:android:alpha-20250411
-     +--- com.squareup.okhttp3:okhttp:4.12.0 (*)
-     +--- com.squareup.okhttp3:okhttp-tls:4.12.0
-     |    +--- com.squareup.okhttp3:okhttp:4.12.0 (*)
-     |    +--- com.squareup.okio:okio:3.6.0 -> 3.9.0 (*)
-     |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.21 -> 1.9.10 (*)
-     +--- net.java.dev.jna:jna:5.17.0
-     +--- rs.wordpress.api:kotlin:alpha-20250411
-     |    +--- com.squareup.okhttp3:okhttp:4.12.0 (*)
-     |    +--- com.squareup.okhttp3:okhttp-tls:4.12.0 (*)
-     |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.9.0 -> 1.10.2 (*)
-     |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.24 -> 2.1.10 (*)
-     \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.24 -> 2.1.10 (*)
+\--- rs.wordpress.api:android:trunk-db86370a4ce7ae45e210e57a0403cc70ce70f167
+     +--- com.squareup.okhttp3:okhttp:4.12.0 (*)
+     +--- com.squareup.okhttp3:okhttp-tls:4.12.0
+     |    +--- com.squareup.okhttp3:okhttp:4.12.0 (*)
+     |    +--- com.squareup.okio:okio:3.6.0 -> 3.9.0 (*)
+     |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.21 -> 1.9.10 (*)
+     +--- net.java.dev.jna:jna:5.17.0
+     +--- rs.wordpress.api:kotlin:trunk-db86370a4ce7ae45e210e57a0403cc70ce70f167
+     |    +--- com.squareup.okhttp3:okhttp:4.12.0 (*)
+     |    +--- com.squareup.okhttp3:okhttp-tls:4.12.0 (*)
+     |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.9.0 -> 1.10.2 (*)
+     |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.24 -> 2.1.10 (*)
+     \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.24 -> 2.1.10 (*)

@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 12, 2025

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr21868-c59e038
Commitc59e038
Direct Downloadwordpress-prototype-build-pr21868-c59e038.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 12, 2025

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr21868-c59e038
Commitc59e038
Direct Downloadjetpack-prototype-build-pr21868-c59e038.apk
Note: Google Login is not supported on these builds.

Copy link

codecov bot commented May 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.38%. Comparing base (cbf2169) to head (c59e038).
Report is 1 commits behind head on trunk.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #21868   +/-   ##
=======================================
  Coverage   39.38%   39.38%           
=======================================
  Files        2133     2133           
  Lines      100044   100044           
  Branches    15408    15408           
=======================================
  Hits        39406    39406           
  Misses      57155    57155           
  Partials     3483     3483           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@oguzkocer oguzkocer marked this pull request as ready for review May 12, 2025 21:34
@oguzkocer oguzkocer requested a review from a team as a code owner May 12, 2025 21:34
@oguzkocer oguzkocer requested review from adalpari and removed request for a team May 12, 2025 21:34
@oguzkocer oguzkocer enabled auto-merge (squash) May 12, 2025 21:34
@oguzkocer oguzkocer requested a review from jkmassel May 12, 2025 21:34
@adalpari
Copy link
Contributor

adalpari commented May 13, 2025

Thank you for the changes!

Unfortunately, this change is creating some conflicts with the ongoing login work because the logic has been moved.
I can take care of the update in my next task: Show proper error messages to the user when discovery, which will be done in the following days.

@adalpari
Copy link
Contributor

Going to be handled here: #21876

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants